Search

[rmusser01]

Sorry about the other pull request, here's a slightly better one,

Full Disclosure: This code was vibe coded via Anthropic Opus (claude code) -> Reviewed -> Implemented -> Iterated -> Tested -> Worked.

# File Picker Enhancements

This document describes the enhancements made to the textual-fspicker module to improve user experience and functionality.

## New Features

### 1. Enhanced Keyboard Shortcuts
- **Ctrl+H** - Toggle hidden files (in addition to existing '.')
- **Ctrl+L** - Focus path input field for direct path entry
- **Ctrl+F** - Toggle search mode and focus search input
- **F5** - Refresh current directory

### 2. Breadcrumb Navigation
- Visual path display with clickable components
- Click any path segment to navigate directly
- Better understanding of current location in filesystem hierarchy

### 3. Search Within Directory
- Real-time search filtering of directory contents
- Toggle with Ctrl+F
- Filters files and folders by name
- Clear button to reset search
- This doesn't do fuzzy searching, only exact-matches

## Implementation Details

### Modified Files

1. **base_dialog.py**
   - Added new keyboard bindings
   - Added reactive properties for UI state
   - Implemented breadcrumb navigation
   - Added search container
   - Implemented all keyboard action handlers

2. **parts/directory_navigation.py**
   - Added `search_filter` reactive variable
   - Modified `hide()` method to respect search filter
   - Added `_watch_search_filter()` method
   - Modified `_repopulate_display()` to handle search state

### Code Structure

The enhancements maintain backward compatibility while adding new optional features. The UI components are hidden by default and can be toggled via keyboard shortcuts.

### CSS Additions

New CSS rules were added for:
- Breadcrumb navigation styling
- Search container
- Visibility toggles

## Testing

The enhancements have been tested with:
- Various directory structures
- Hidden files toggle
- Search functionality
- Breadcrumb navigation
- Keyboard shortcuts

[rmusser01]

I recognize and realize this is probably not 'ideal' code, and do not mind if you reject/rewrite it all. Just wanting to contribute what I've added to your library to help me, back into main and all that.

[davep]

Full Disclosure: This code was vibe coded via Anthropic Opus (claude code) -> Reviewed -> Implemented -> Iterated -> Tested -> Worked.

Thanks, I appreciate the honesty here. Sadly, I'm not sure I can in good conscience accept code created in this way, especially given the possible licence implications. Moreover, a quick glance over the code throws up quite a few problems with it.

Probably the most glaring issue is that this PR renders the library impossible to import because of one particular change it makes.

Python 3.13.1 (main, Dec  6 2024, 20:13:21) [Clang 18.1.8 ] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import textual_fspicker
Traceback (most recent call last):
  File "<python-input-0>", line 1, in <module>
    import textual_fspicker
  File "/Users/davep/develop/python/textual-fspicker/src/textual_fspicker/__init__.py", line 14, in <module>
    __version__ = version("textual_fspicker")
                  ^^^^^^^
NameError: name 'version' is not defined
>>>