Skip to content

Add argument 'job_script_epilogue' #677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 18, 2025

Conversation

maneesh29s
Copy link
Contributor

Closes #639

This allows user to specify commands that should be run after the worker command has exited.

The working is similar to 'job_script_prologue' argument.

This allows user to specify commands that should be run after
the worker command has exited.

The working is similar to 'job_script_prologue' argument.
@maneesh29s
Copy link
Contributor Author

maneesh29s commented Jan 11, 2025

I have not added any new example in the documentation for this (I see there's an entire section dedicated to job_script_prologue).

So question to maintainers, do you think it is necessary to give examples for this parameter seperately?

@guillaumeeb
Copy link
Member

So sorry that we never provided any feedback here, this looks perfect to me. @jacobtomlinson any thought?

About the documentation, just a mention of this arg in the doc section you are pointing to would have been great, but I guess you are probably not into this, are you @maneesh29s?

@maneesh29s
Copy link
Contributor Author

No problem, I will update the documentation

Copy link
Member

@jacobtomlinson jacobtomlinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure this looks great to me!

@maneesh29s
Copy link
Contributor Author

@guillaumeeb I have updated the docs as you suggested.

@guillaumeeb guillaumeeb merged commit 6dc463d into dask:main Apr 18, 2025
10 of 11 checks passed
@guillaumeeb
Copy link
Member

Thanks @maneesh29s !

@maneesh29s maneesh29s deleted the job-script-epilogue branch April 18, 2025 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Job script epilogue
3 participants