-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Add write_essay_by_author
and update Pattern metadata
#1542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add write_essay_by_author
and update Pattern metadata
#1542
Conversation
# CHANGES - Add `os` and `strings` packages to imports - Implement dynamic URL handling with environment variables - Refactor provider configuration to support URL templates - Reorder providers for consistent key order in ProviderMap - Extract and parse template variables from BaseURL - Use environment variables or default values for templates - Replace template with actual values in BaseURL
### CHANGES - Add tags and descriptions for five new creative and analytical patterns. - Introduce `analyze_terraform_plan` for infrastructure review. - Add `write_essay_by_author` for stylistic writing. - Include `summarize_board_meeting` for corporate notes. - Introduce `create_mnemonic_phrases` for memory aids. - Update and clean pattern description data files. - Sort the pattern explanations list alphabetically.
write_essay_by_author
and update Pattern metadata
…variable usage ## CHANGES - Rename `write_essay` to `write_essay_pg` for Paul Graham style - Rename `write_essay_by_author` to `write_essay` with author variable - Update pattern descriptions to reflect naming changes - Fix duplicate `write_essay_pg` entry in pattern descriptions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR streamlines pattern metadata formatting while introducing five new patterns and refactoring the essay-writing patterns for improved flexibility and backward compatibility.
- Consolidates JSON arrays to single-line formatting and renames the classic essay pattern from "write_essay" to "write_essay_pg".
- Introduces a new parameterized "write_essay" pattern using the {{author_name}} variable and updates related system prompt documentation for both essay patterns.
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated no comments.
File | Description |
---|---|
web/static/data/pattern_descriptions.json | Reformats tag arrays, renames "write_essay" to "write_essay_pg", and adds new pattern entries. |
patterns/write_essay_pg/system.md | Adds a complete system prompt for the Paul Graham–style essay writing pattern. |
patterns/write_essay/system.md | Transforms the essay pattern to be parameterized via {{author_name}} and updates instructions. |
patterns/suggest_pattern/user_updated.md | Updates documentation for Fabric usage and details many pattern options, including the new ones. |
Comments suppressed due to low confidence (2)
web/static/data/pattern_descriptions.json:989
- The renaming of 'write_essay' to 'write_essay_pg' alongside the addition of a new 'write_essay' pattern could be confusing. Consider updating the documentation to clearly differentiate their intended use cases.
"patternName": "write_essay_pg",
web/static/data/pattern_descriptions.json:3
- Since identical changes are applied in both 'web/static/data/pattern_descriptions.json' and 'Pattern_Descriptions/pattern_descriptions.json', consider consolidating these duplicate files to ease maintenance.
{
Add
write_essay_by_author
and update Pattern metadataSummary
This PR updates the pattern descriptions and related files in the Fabric project. The main changes involve consolidating pattern metadata, adding new patterns, and renaming the
write_essay
pattern towrite_essay_pg
while creating a new parameterizedwrite_essay
pattern.Files Changed
Pattern_Descriptions/pattern_descriptions.json
analyze_paper_simple
: Analyze research papers for findings and scientific rigoranalyze_terraform_plan
: Analyze Terraform plans for infrastructure changes and securitycreate_mnemonic_phrases
: Create memorable mnemonic sentences from given wordssummarize_board_meeting
: Convert board meeting transcripts to formal noteswrite_essay
: New parameterized essay writer using{{author_name}}
variablecreate_coding_feature
patternwrite_essay
→write_essay_pg
(Paul Graham style)Pattern_Descriptions/pattern_extracts.json
write_essay_pg
patternpatterns/pattern_explanations.md
write_essay
to reflect it now uses anauthor_name
variablewrite_essay_pg
to clarify it's specifically Paul Graham stylepatterns/suggest_pattern/user.md
write_essay
→write_essay_pg
renamepatterns/write_essay/system.md
{{author_name}}
variable: Allows writing in any author's stylepatterns/write_essay_pg/system.md
web/static/data/pattern_descriptions.json
Code Changes
The most significant code change is the transformation of the
write_essay
pattern from a hardcoded Paul Graham style to a flexible, parameterized pattern:Reason for Changes
write_essay
pattern allows users to write in any author's style, not just Paul Graham'swrite_essay_pg
Impact of Changes
write_essay_pg
Test Plan
write_essay
pattern with various author nameswrite_essay_pg
still produces Paul Graham-style essaysAdditional Notes