Skip to content

Fix Fabric Web timeout error #1641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 21, 2025
Merged

Conversation

ksylvan
Copy link
Collaborator

@ksylvan ksylvan commented Jul 21, 2025

Fix Fabric Web timeout error

Summary

This pull request increases the proxy timeout configuration in the Vite development server from 30 seconds to 15 minutes (900,000ms) for API requests and pattern/model/session name endpoints.

Related Issues

Closes #1604

Files Changed

  • web/vite.config.ts: Modified proxy timeout settings for development server configuration

Code Changes

The changes involve updating two proxy configurations in the Vite config file:

  1. API proxy timeout update:
'/api': {
  target: FABRIC_BASE_URL,
  changeOrigin: true,
- timeout: 30000,
+ timeout: 900000,
  rewrite: (path) => path.replace(/^\/api/, ''),
  1. Patterns/models/sessions proxy timeout update:
'^/(patterns|models|sessions)/names': {
  target: FABRIC_BASE_URL,
  changeOrigin: true,
- timeout: 30000,
+ timeout: 900000,

Reason for Changes

The timeout increase from 30 seconds to 15 minutes addresses scenarios where:

  • API requests may take longer to process, particularly for complex operations
  • Pattern, model, or session name retrieval operations may require extended processing time
  • Network latency or server processing delays could cause legitimate requests to timeout prematurely

This change prevents development workflow interruptions caused by timeout errors on slower operations.

Impact of Changes

Positive impacts:

  • Eliminates premature timeouts during development for long-running operations
  • Improves developer experience by allowing complex requests to complete
  • Reduces frustration from timeout errors on legitimate operations

Potential concerns:

  • Longer timeout periods may mask actual performance issues
  • Failed requests will now hang for up to 15 minutes before timing out
  • Memory usage could increase if multiple long-running requests accumulate

Test Plan

  • Test API endpoints that previously timed out at 30 seconds
  • Verify that legitimate long-running operations now complete successfully
  • Confirm that truly failed requests still eventually timeout (within 15 minutes)
  • Monitor development server performance with the extended timeout

Additional Notes

This change only affects the development environment proxy configuration and will not impact production deployments. The 15-minute timeout should accommodate most legitimate long-running operations while still providing an upper bound for failed requests. Consider monitoring actual request durations to determine if this timeout value needs further adjustment based on real-world usage patterns.

ksylvan and others added 2 commits July 21, 2025 12:16
### CHANGES

- Increase `/api` proxy timeout to 900,000 ms
- Increase `/names` proxy timeout to 900,000 ms
@ksylvan ksylvan merged commit 9a2ff98 into danielmiessler:main Jul 21, 2025
1 check passed
@ksylvan ksylvan deleted the 0721-web-timeout-fix branch July 21, 2025 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Fabric Web timeout error: Failed to fetch Chat stream
1 participant