refactor(repo): address walkthrough comments #86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for chipper-wisp-c7553e ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
QZera
changed the title
QZera
force-pushed
the
refactor/fa31a13-address-walkthrough-comments
branch
from
06f1963 to
a091da7
Compare
Signed-off-by: Zacharias Fragkiadakis <[email protected]>
…-host-app-message use-host-app-message composable combines the 2 postMessage-related composables (use-post-message-to-radicle-interface, and use-radicle-interface-message) Signed-off-by: Zacharias Fragkiadakis <[email protected]>
Use the term `radicle explorer` in documentation. Use the generic term `host-app` in code. Signed-off-by: Zacharias Fragkiadakis <[email protected]>
Signed-off-by: Zacharias Fragkiadakis <[email protected]>
due to valibot's modular design, it offers a reduced bundle size, compared to zod After the refactor the bundle size was reduced by ~60kb Signed-off-by: Zacharias Fragkiadakis <[email protected]>
Signed-off-by: Zacharias Fragkiadakis <[email protected]>
Signed-off-by: Zacharias Fragkiadakis <[email protected]>
QZera
force-pushed
the
refactor/fa31a13-address-walkthrough-comments
branch
from
a091da7 to
a0a2b84
Compare
maninak
reviewed
Sep 4, 2024
maninak
reviewed
Sep 4, 2024
maninak
approved these changes
Sep 4, 2024
…tension Signed-off-by: Zacharias Fragkiadakis <[email protected]>
Signed-off-by: Zacharias Fragkiadakis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes fa31a13