fix(other): fix some GitHub module issues#1739
Open
IrAlfred wants to merge 2 commits intocypht-org:masterfrom
Open
fix(other): fix some GitHub module issues#1739IrAlfred wants to merge 2 commits intocypht-org:masterfrom
IrAlfred wants to merge 2 commits intocypht-org:masterfrom
Conversation
IrAlfred
force-pushed
the
fix-some-github-module-issues
branch
from
fe26b5f to
6653bfa
Compare
IrAlfred
changed the title
IrAlfred
changed the title
kroky
reviewed
Oct 13, 2025
kroky
reviewed
Oct 13, 2025
IrAlfred
force-pushed
the
fix-some-github-module-issues
branch
from
6653bfa to
2c07ac3
Compare
IrAlfred
force-pushed
the
fix-some-github-module-issues
branch
from
2c07ac3 to
e288597
Compare
kroky
reviewed
Dec 4, 2025
| foreach ($ids as $key => $id) { | ||
| $details = Hm_IMAP_List::dump($id); | ||
| $mailbox = Hm_IMAP_List::get_connected_mailbox($id, $this->cache); | ||
| if (!$mailbox || !$mailbox->authed()) { |
Member
There was a problem hiding this comment.
If a mailbox is configured but inaccessible at the moment, we should show an error to the user with details about which mailbox is inaccessible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the following issues: