fix: setup delete not working (#3191) #3192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

dennisrijsdijk wants to merge 3 commits into crowbartools:v5 from dennisrijsdijk:fix/3191-setup-not-being-removed

Collaborator

dennisrijsdijk commented Jun 21, 2025

Description of the Change

Fix the deletion of setup components not working
Improve setup handling for hotkeys

Applicable Issues

Testing

Created an item in each of the following categories:

commands
counters
currencies
effect queues
events
event sets
hotkeys
preset effect lists
timers
scheduled effect lists
variable macros
viewer roles
rank ladders
quick actions

Added each to the same setup
Used Remove Setup to remove components from the setup
Verified all components are gone
Imported the setup
Repeated steps 3 and 4

dennisrijsdijk added 3 commits

June 21, 2025 23:23


          fix: setup delete not working (crowbartools#3191)

b020960


          fix: currency deletion

d584b80


          fix: hotkey handling in setups

8eeb070

dennisrijsdijk requested a review from ebiggz as a code owner

June 21, 2025 22:03

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet