This repository was archived by the owner on Nov 2, 2021. It is now read-only.
Issue #2485 - Fix rounding Error #2486
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sarathsp06 - Fixes Issue #2485 |
sarathsp06
reviewed
Jun 5, 2021
| if (percentageValue > 0 && percentageValue < 1) | ||
| { | ||
| confirmedCasesText = "For every 1000 confirmed cases"; | ||
| percentageValue = percentageValue * 10 |
There was a problem hiding this comment.
For semantics sake, i wouldn't call it percentageValue anymore, preferably return it here or use a more appropriate name
| const percentageDescription = (percentageValue, description) => { | ||
| let confirmedCasesText | ||
|
|
||
| if (percentageValue > 0 && percentageValue < 1) |
There was a problem hiding this comment.
A small inconsistency here
- Since
percentageDescriptionis always called for percentageValue > 0 , no need to check forpercentageValue > 0 - Its good to test
percentageValue > 0but a case when percentage value <= 0 has to be handled then
|
Thanks @codelear for the PR and @sarathsp06 for the inputs. This should be fixed via 2a0fba8. I wasn't in favour of switching the text between per 100 and per 1000 based on the percentage value, so I modified the formatting logic to show decimals if the percentage is between 0 and 1. Closing this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
The rounding off was presenting incorrect results when the percentage was less than 1. So I fixed this by checking if the percentage is between 0 and 1 and scaling the value by 10.
Relevant Issues
Fixes #2485
Checklist
Screenshots