Skip to content

Fix weighted_summed_score in GEval metrics. #854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Fix weighted_summed_score in GEval metrics. #854

merged 1 commit into from
Jun 26, 2024

Conversation

SighingSnow
Copy link
Contributor

A simple fix on issue #853 .

Original behavior:

For example, ('8', '0.01') and ('8', '0.001') are both in the score_logprobs,
After traversing ('8', '0.01'), token_linear_probability['8'] = 0.01, and sum_linear_probability=0.01
When coming to ('8', '0.001'), token_linear_probability['8'] = 0.001, and sum_linear_probability=0.011.

This will leads to the normalization error in the No.378 line.

Current behavior:

After traversing ('8', '0.01'), token_linear_probability['8'] = 0.01, and sum_linear_probability=0.01
When coming to ('8', '0.001'), token_linear_probability['8'] = 0.011, and sum_linear_probability=0.011.

Copy link

vercel bot commented Jun 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
evals-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 26, 2024 3:55am

@penguine-ip
Copy link
Contributor

@SighingSnow Great catch, TYSM!

@penguine-ip penguine-ip merged commit 222e58f into confident-ai:main Jun 26, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants