Stateless Metrics #806
Merged
Stateless Metrics #806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
penguine-ip
reviewed
Jun 10, 2024
| @@ -30,6 +31,13 @@ class AnswerRelvancyVerdict(BaseModel): | |||
|
|
|||
|
|
|||
| class AnswerRelevancyMetric(BaseMetric): | |||
|
|
|||
| _statements: ContextVar[List[str]] = ContextVar('statements', default=[]) | |||
There was a problem hiding this comment.
Is it possible for context variables to default to None? Since right now we default to none: https://github.com/confident-ai/deepeval/blob/main/deepeval/metrics/base_metric.py#L7
Also add error as well.
deepeval/metrics/bias/bias.py
Outdated
| @@ -203,11 +268,56 @@ def is_successful(self) -> bool: | |||
| self.success = False | |||
| else: | |||
| try: | |||
| self.success = self.score <= self.threshold | |||
| self._success.set(self.score >= self.threshold) | |||
There was a problem hiding this comment.
Careful copy n pasting (should be self.score <= self.threshold instead)
- Fixed ContextVar bug and moved it to init method in each metric class so that the variables are not shared among metric object instantiations. - Removed shared context variables and defined them in BaseMetric class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stateless Support for Metrics
Stateless support was implemented for all metrics except RAGAS and knowledge retention. This involves adding context variables and changing the measure and a_measure accordingly. The measure method is more complex, because there is also support for async_mode, which involved implementing an additional function to overcome the loss of information due to using context variables in coroutines. In addition, the indicator was adapted to support a_measure.