update-apps: fix restore path, add PBS support and improve restore messages#12528
Open
omertahaoztop wants to merge 1 commit intocommunity-scripts:mainfrom
Open
update-apps: fix restore path, add PBS support and improve restore messages#12528omertahaoztop wants to merge 1 commit intocommunity-scripts:mainfrom
omertahaoztop wants to merge 1 commit intocommunity-scripts:mainfrom
Conversation
The restore step was hardcoded to look for a .tar.zst file at /var/lib/vz/dump/, which does not work for PBS or any non-default storage. Replace the hardcoded path with pvesm list to find the latest backup for the container in the selected storage. This works for all storage types including PBS (backup/ct/CTID/TIMESTAMP) and traditional file storages (vzdump-lxc-*.tar.zst) without any extra plumbing. Also improve log messages in the restore flow to show container ID, exit code, storage name and resolved backup entry so it is clear what failed and where the restore is coming from.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✍️ Description
update-apps.shrestore step was hardcoded to/var/lib/vz/dump/*.tar.zst, which silently fails for PBS and any non-default storage.Changes:
pvesm listto dynamically resolve the latest backup from the selected storage — works for both PBS and traditional file-based storages with no extra plumbing🔗 Related Issue
Fixes #
✅ Prerequisites
🛠️ Type of Change
README,AppName.md,CONTRIBUTING.md, or other docs.