fix: whitelist var_searchdomain and fix the handling of var_ns and va…#12521
Merged
MickLesk merged 1 commit intocommunity-scripts:mainfrom Mar 4, 2026
Merged
fix: whitelist var_searchdomain and fix the handling of var_ns and va…#12521MickLesk merged 1 commit intocommunity-scripts:mainfrom
MickLesk merged 1 commit intocommunity-scripts:mainfrom
Conversation
…r_searchdomain in build.func
CrazyWolf13
approved these changes
Mar 3, 2026
michelroegl-brunner
approved these changes
Mar 3, 2026
Member
michelroegl-brunner
left a comment
There was a problem hiding this comment.
@MickLesk also check please.
MickLesk
approved these changes
Mar 4, 2026
Member
MickLesk
left a comment
There was a problem hiding this comment.
should be okay, i dont use it. so the user should report afterwards
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✍️ Description
Currently misc/build.func does not allow setting
var_searchdomainbecause it is not in the whitelist. Thenvar_nsandvar_searchdomainare not properly set with the right flags when creatingPCT_OPTIONS_STRING✅ Prerequisites (X in brackets)
🛠️ Type of Change (X in brackets)
README,AppName.md,CONTRIBUTING.md, or other docs.