Skip to content

fix: whitelist var_searchdomain and fix the handling of var_ns and va…#12521

Merged
MickLesk merged 1 commit intocommunity-scripts:mainfrom
tommoyer:main
Mar 4, 2026
Merged

fix: whitelist var_searchdomain and fix the handling of var_ns and va…#12521
MickLesk merged 1 commit intocommunity-scripts:mainfrom
tommoyer:main

Conversation

@tommoyer
Copy link
Contributor

@tommoyer tommoyer commented Mar 3, 2026

✍️ Description

Currently misc/build.func does not allow setting var_searchdomain because it is not in the whitelist. Then var_ns and var_searchdomain are not properly set with the right flags when creating PCT_OPTIONS_STRING

✅ Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to website-related JSON files or metadata.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

Copy link
Member

@michelroegl-brunner michelroegl-brunner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MickLesk also check please.

@CrazyWolf13 CrazyWolf13 requested a review from MickLesk March 4, 2026 04:51
Copy link
Member

@MickLesk MickLesk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be okay, i dont use it. so the user should report afterwards

@MickLesk MickLesk merged commit 199483b into community-scripts:main Mar 4, 2026
2 checks passed
@MickLesk MickLesk added the bugfix label Mar 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants