Draft
Conversation
- Move run_preflight from build_container() into install_script() after header_info - Shows: Header → preflight checks → 2s pause → clear (via next header_info call) - On failure: show summary + exit cleanly (no ERR trap) - Change all return 1 → return 0 in preflight functions (prevents ERR trap under set -Ee) - Remove PREFLIGHT_DONE guard from build_container (no longer needed)
- New preflight_repo_access() warns if enterprise repos are active without subscription - Scans /etc/apt/sources.list.d/ for enterprise.proxmox.com entries - Tests HTTP access (detects 401/403 Unauthorized) - Warning only — not a blocker (packages come from pve-no-subscription repo)
- Test Debian (deb.debian.org, security.debian.org), Ubuntu (archive.ubuntu.com, security.ubuntu.com) and Alpine (dl-cdn.alpinelinux.org) repos via HTTP HEAD - Selects target repos based on var_os and var_version from the CT script - Warning only (not a hard fail) to support local mirrors and apt-cacher-ng setups - Shows which repo host failed and with what HTTP status code - Catches connectivity issues before container creation and apt-get/apk failures
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✍️ Description
tbd - wip
🔗 Related Issue
Fixes #
✅ Prerequisites (X in brackets)
🛠️ Type of Change (X in brackets)
README,AppName.md,CONTRIBUTING.md, or other docs.