Skip to content

Stale bot: staleness after 1 year, close after 2 years #1102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

maelvls
Copy link
Member

@maelvls maelvls commented Jul 8, 2025

Slack thread.

I'm annoyed at our stale bot.

We originally turned it on because we (Venafi) used to look at the number of open issues as a vanity metric to tell us that we are doing a good job.... but:

  1. We no longer look at this number.
  2. These tons of stale messages everywhere are super verbose and annoying.

I suggest issues and PRs become stale after one year, and close them after 2 years. That should reduce the number of stale messages, but still be useful.

Before:

|---------90d----------|----30d----|----30d----|              total = 5 months
active                  stale       rotten     closed

After:

       (1 year)        (6 months)  (6 months)
|--------365d---------|---182d----|---182d----|               total = 2 years
active                 stale       rotten     closed

@cert-manager-prow cert-manager-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 8, 2025
@cert-manager-prow
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@cert-manager-prow cert-manager-prow bot added the dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. label Jul 8, 2025
@cert-manager-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign inteon for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 8, 2025
@cert-manager-prow cert-manager-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 8, 2025
@maelvls maelvls marked this pull request as ready for review July 8, 2025 09:46
@cert-manager-prow cert-manager-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 8, 2025
@maelvls
Copy link
Member Author

maelvls commented Jul 8, 2025

We have had a chat. There are two use-cases I hadn't thought of:

  • The stale notifications are used to remind ourselves of some issues we have forgotten about.
  • The stale bot is still useful when we don't want to be closing an issue and be seen as obstructive; the bot is a machine, no one can complain.

Not sure whether continuing this PR would make sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant