-
Notifications
You must be signed in to change notification settings - Fork 1
Add name parsing functionality with mappers for various name components #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implemented InitialMapper to handle initials and their mapping. - Created LastnameMapper for parsing last names, including prefixes and suffixes. - Added MiddlenameMapper for handling middle names. - Developed NicknameMapper to extract nicknames with customizable delimiters. - Introduced SalutationMapper for parsing salutations. - Implemented SuffixMapper to handle suffixes in names. - Created Name class to encapsulate name parts and provide formatted output. - Added abstract classes for name parts, including AbstractPart, NamePart, and GivenNamePart. - Developed specific classes for Firstname, Lastname, Initial, Middlename, Nickname, Salutation, and Suffix. - Included PreNormalizedPart for handling normalized versions of parts. - Enhanced parser functionality to split and map names effectively.
fdb9a5c
to
fccdfd4
Compare
Orrison
requested changes
Jun 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's also make sure to copy over the tests so we can ensure this is all still working via those.
5f0c89b
to
81b97f5
Compare
2aad851
to
2ead919
Compare
Orrison
requested changes
Jun 25, 2025
Orrison
approved these changes
Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technical Description
Port over of name parsing functionality.
Any deployment steps required?
Are any Feature Flags and/or Data Migrations that can eventually be removed Added?
Before contributing and submitting this PR, make sure you have Read, agree, and are compliant with the contributing guidelines.