Skip to content

Add name parsing functionality with mappers for various name components #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jun 26, 2025

Conversation

ankit-canyon
Copy link
Contributor

@ankit-canyon ankit-canyon commented Jun 12, 2025

Technical Description

Port over of name parsing functionality.

Any deployment steps required?

No

Are any Feature Flags and/or Data Migrations that can eventually be removed Added?

No


Before contributing and submitting this PR, make sure you have Read, agree, and are compliant with the contributing guidelines.

- Implemented InitialMapper to handle initials and their mapping.
- Created LastnameMapper for parsing last names, including prefixes and suffixes.
- Added MiddlenameMapper for handling middle names.
- Developed NicknameMapper to extract nicknames with customizable delimiters.
- Introduced SalutationMapper for parsing salutations.
- Implemented SuffixMapper to handle suffixes in names.
- Created Name class to encapsulate name parts and provide formatted output.
- Added abstract classes for name parts, including AbstractPart, NamePart, and GivenNamePart.
- Developed specific classes for Firstname, Lastname, Initial, Middlename, Nickname, Salutation, and Suffix.
- Included PreNormalizedPart for handling normalized versions of parts.
- Enhanced parser functionality to split and map names effectively.
@ankit-canyon ankit-canyon requested a review from a team as a code owner June 12, 2025 09:33
@ankit-canyon ankit-canyon added the enhancement New feature or request label Jun 12, 2025
@ankit-canyon ankit-canyon marked this pull request as draft June 12, 2025 12:37
@ankit-canyon ankit-canyon force-pushed the features/parserSupport branch from fdb9a5c to fccdfd4 Compare June 12, 2025 14:29
@ankit-canyon ankit-canyon marked this pull request as ready for review June 12, 2025 14:32
Copy link
Contributor

@Orrison Orrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also make sure to copy over the tests so we can ensure this is all still working via those.

@ankit-canyon ankit-canyon force-pushed the features/parserSupport branch from 5f0c89b to 81b97f5 Compare June 25, 2025 13:44
@ankit-canyon ankit-canyon force-pushed the features/parserSupport branch from 2aad851 to 2ead919 Compare June 25, 2025 17:51
@ankit-canyon ankit-canyon requested a review from Orrison June 25, 2025 18:27
@ankit-canyon ankit-canyon requested a review from Orrison June 26, 2025 06:56
@Orrison Orrison merged commit 62e0f55 into main Jun 26, 2025
3 checks passed
@Orrison Orrison deleted the features/parserSupport branch June 26, 2025 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants