Skip to content

[ADVAPP-1726]: Issues with notifying Users of subscription created for them #1760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Aug 6, 2025
Merged

[ADVAPP-1726]: Issues with notifying Users of subscription created for them #1760

Changes from 6 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
f6518f1
ADVAPP-1726: Bale out if the subscribable is null
Aug 4, 2025
3cd0eff
ADVAPP-1726: Fix if check
Aug 4, 2025
1a59b0a
ADVAPP-1726: Add afterCommit() check.
Aug 5, 2025
258eabd
chore: fix code style
krlmrr Aug 5, 2025
4e99e8d
ADVAPP-1726: Implement the ShouldHandleEventsAfterCommit contract
Aug 5, 2025
19bbff8
chore: fix code style
krlmrr Aug 5, 2025
02b1f3d
ADVAPP-1726: Change the implimentation
Aug 5, 2025
bcb81b2
chore: fix code style
krlmrr Aug 5, 2025
6b54865
ADVAPP-1726: Change the implimentation to the listener
Aug 5, 2025
a3b8a70
chore: fix code style
krlmrr Aug 5, 2025
da3eb54
ADVAPP-1726: Change the implements
Aug 6, 2025
c755066
chore: fix code style
krlmrr Aug 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion app-modules/notification/src/Observers/SubscriptionObserver.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,9 @@
use AdvisingApp\Notification\Events\SubscriptionCreated;
use AdvisingApp\Notification\Events\SubscriptionDeleted;
use AdvisingApp\Notification\Models\Subscription;
use Illuminate\Contracts\Events\ShouldHandleEventsAfterCommit;

class SubscriptionObserver
class SubscriptionObserver implements ShouldHandleEventsAfterCommit
{
public function created(Subscription $subscription): void
{
Expand Down