Skip to content

Fixes to Spanish translation #2407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 25, 2025
Merged

Fixes to Spanish translation #2407

merged 1 commit into from
Jul 25, 2025

Conversation

jorgesumle
Copy link
Contributor

@jorgesumle jorgesumle commented Jul 23, 2025

Description

It fixes really ugly translations and mistakes (it looks like some strings were translated by a machine).

Pull Request - Checklist

  • Initial Manual Tests Passed
  • Double check modified code and verify it with the feature/task requirements
  • Format code
  • Look for code duplication
  • Clear naming for variables and methods
  • Manual tests in accessibility mode (TalkBack on Android) passed

I have a question: should the Spanish translation use "usted" (formal) or "tú" (informal)? It looks like the Spanish translation is inconsistent in this regard: sometimes it uses "usted", other times it uses "tú".

No sé quién ha contribuido principalmente a la traducción al español o quién debería decidir esto, pero creo que se debe elegir o si se usa usted o tú, y no mezclarlos (@ktecho).

@jorgesumle
Copy link
Contributor Author

Oh, and the text returned from the getOrdinal function in lib/src/screens/seed/seed_verification/seed_verification_step_view.dart is not translatable. In Spanish it should return "1.ª", "2.ª", "3.ª" and so on, as the word "palabra" is feminine. I think that should be an issue not only for Spanish, but also for other languages. I haven't fixed that.

Copy link
Contributor

@rottenwheel rottenwheel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. @OmarHatem28 please merge #2408 before this one, 2407, so that there's no conflicts. Thanks!

@OmarHatem28 OmarHatem28 merged commit 8f4eed4 into cake-tech:main Jul 25, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants