feat: enable DNSSEC BIP353 in PSBT #2397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OmarHatem28
approved these changes
Jul 18, 2025
TheBlueMatt
reviewed
Jul 21, 2025
| final cwOutput = cwOutputs.where((e) => e.address.toLowerCase() == output.address.toAddress().toLowerCase()).firstOrNull; | ||
| if (cwOutput != null) { | ||
| final bip353Name = utf8.encode(cwOutput.extra['bip353_name'] as String); | ||
| final bip353Rsig = base64.decode(cwOutput.extra['bip353_rsig'] as String); |
There was a problem hiding this comment.
Just including the RSIG is insufficient as proof - you need to include the full tree. That means DNSKEY, DS, and RSIG recors from the root through the TLD to the domain, to the record itself (sometimes also NSEC/NSEC3 records if there's a wildcard in the path). Note that elsewhere you error if "multiple rsig records found" which is also wrong, multiple RSIG records is totally allowed, and in fact common, eg during DNSSEC key rotation. You might consider using the lookup logic in https://git.bitcoin.ninja/?p=dnssec-prover;a=summary instead.
There was a problem hiding this comment.
Hey @TheBlueMatt, we are now using dnssec-prover package #2401
MrCyjaneK
added a commit
that referenced
this pull request
Jul 25, 2025
* feat: enable DNSSEC BIP353 in PSBT * chore: put bitcoin view only behind a featureflag
MrCyjaneK
added a commit
that referenced
this pull request
Jul 28, 2025
* feat: enable DNSSEC BIP353 in PSBT * chore: put bitcoin view only behind a featureflag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
feat: enable DNSSEC BIP353 in PSBT
This PR enables hardware wallets to validate DNSSEC proof of a BIP353 parsed address
Pull Request - Checklist