CW-974: Add support for automatic node switching. #2361
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change: - Adds isTrustedNodeForSwitching property to Node class. - Adds UI Checkbox to mark a node as trusted for automatic switching in Node create or edit form. - Implements checkNodeHealth method in wallet classes to verify node connectivity. - Adds NodeSwitchingService for managing automatic node switching based on health checks. - Adds setting option for user to enable/disable automated node switching
…es in NodeSwitchingService
This change: - Moves enable automatic node switch to the Manage Nodes Page - Adds check to verify node health before attempting to sync in EVM, Sol and Tron Wallets. - Modifies trusted ndoes list for monero - Adds trigger for Node Health Check when app resumes from background
…k interval for node switch
This change adds additional checks for token balance in EVM, Solana and Tron Wallets in checkNodeHealth.
…Allow-Automatic-Node-Switching
…ake-tech/cake_wallet into Allow-Automatic-Node-Switching
…Allow-Automatic-Node-Switching
This change: - Enables more nodes across wallet types for auto switching - Modifies CTA for checkbox - Renames flags to fit
…Allow-Automatic-Node-Switching
OmarHatem28
requested changes
Jul 23, 2025
| value: nodeViewModel.isTrustedNodeForSwitching, | ||
| borderColor: Theme.of(context).colorScheme.surfaceContainerHighest, | ||
| iconColor: Theme.of(context).colorScheme.primary, | ||
| onChanged: (value) => nodeViewModel.isTrustedNodeForSwitching = value, |
There was a problem hiding this comment.
better use the setter as well and make the variable private
cw_evm/lib/evm_chain_wallet.dart
Outdated
| @@ -828,6 +858,7 @@ abstract class EVMChainWalletBase | |||
| _transactionsUpdateTimer = Timer.periodic(const Duration(seconds: 15), (_) { | |||
| _updateTransactions(); | |||
| _updateBalance(); | |||
| _updateEstimatedGasFeeParams(); | |||
There was a problem hiding this comment.
previously it was called every 30 seconds, which I believe is sufficient for this function, now that I see our daily usage, I believe we should check which functions needs to be called frequently and which should be called less frequently so we can decide better and put periodic time accordingly
| break; | ||
| break; | ||
| case 50: | ||
| await migrateExistingNodesToUseAutoSwitching(nodes: nodes); |
There was a problem hiding this comment.
this can be async, no need to be awaited
Suggested change
| await migrateExistingNodesToUseAutoSwitching(nodes: nodes); | |
| migrateExistingNodesToUseAutoSwitching(nodes: nodes); |
…Allow-Automatic-Node-Switching
OmarHatem28
approved these changes
Jul 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number (if Applicable): Fixes #
Description
This change:
Pull Request - Checklist