-
Notifications
You must be signed in to change notification settings - Fork 316
Add GitLab Code Quality report format to lint/breaking file annotations output #3939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
doriable
wants to merge
7
commits into
main
Choose a base branch
from
3926-gitlab-code-quality
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
doriable
commented
Jul 29, 2025
Comment on lines
+344
to
+345
// Fingerprint is a unique identifier for the specific code quality violation. This maps | ||
// to a shake256 digest of the JSON FileAnnotation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using the shake256
digest of the JSON FileAnnotation
for the hash, but open to suggestions on this!
emcfarlane
reviewed
Aug 4, 2025
emcfarlane
reviewed
Aug 4, 2025
emcfarlane
reviewed
Aug 4, 2025
emcfarlane
approved these changes
Aug 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
gitlab-code-quality
as an option tobuf {lint,breaking} --error-format
, e.g.It is important to note that GitLab Code Quality report expects a single JSON array.
Based on the documentation, GitLab Code Quality report also always expects a relative
path based on the repository in the location, and if the location/path is missing, this could
result in Code Quality issues being dropped from report view. It is up to the user to ensure
that their
buf {lint, breaking}
invocations are configured accordingly with their repositories.GitLab Code Quality report also always expects all fields to be present.
Fixes #3926