More external packages #790
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sophiebits
reviewed
Jul 15, 2025
js/src/cli.ts
Outdated
Comment on lines
726
to
733
| "@braintrust/", | ||
| "config", | ||
| "lightningcss", | ||
| "@mapbox/node-pre-gyp", | ||
| ...additionalPackages, | ||
| ]; | ||
| const knownPackagesFilter = new RegExp( | ||
| `^(${knownPackages.map((pkg) => pkg.replace(/[.*+?^${}()|[\]\\]/g, "\\$&")).join("|")})`, |
There was a problem hiding this comment.
didn't test but perhaps this so that you don't catch all package names that happen to have these prefixes
Suggested change
| "@braintrust/", | |
| "config", | |
| "lightningcss", | |
| "@mapbox/node-pre-gyp", | |
| ...additionalPackages, | |
| ]; | |
| const knownPackagesFilter = new RegExp( | |
| `^(${knownPackages.map((pkg) => pkg.replace(/[.*+?^${}()|[\]\\]/g, "\\$&")).join("|")})`, | |
| "@braintrust", | |
| "config", | |
| "lightningcss", | |
| "@mapbox/node-pre-gyp", | |
| ...additionalPackages, | |
| ]; | |
| const knownPackagesFilter = new RegExp( | |
| `^(${knownPackages.map((pkg) => pkg.replace(/[.*+?^${}()|[\]\\]/g, "\\$&")).join("|")})(?:/|$)`, |
There was a problem hiding this comment.
I made a more invasive change here: https://github.com/braintrustdata/braintrust-sdk/pull/790/files#diff-4f2328e013899dee49744473623d1e46ecec44c3acdf5e10bf908edd59c04413R24
There was a problem hiding this comment.
Thanks for taking a look!
manugoyal
approved these changes
Jul 15, 2025
clutchski
approved these changes
Jul 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mapbox/node-pre-gypas a known binary package (to make external)