Skip to content

[8.3.0] Move Bash runfiles libraries out of Bazel #26304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 16, 2025

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Jun 15, 2025

The Bash libraries in @bazel_tools are replaced with aliases to @rules_shell//shell/runfiles.

This requires skipping load visibility checks for resolved WORKSPACE files, which are going away anyway.

Closes #24219.

PiperOrigin-RevId: 727843225
Change-Id: I00744bd30c637cae450d63b859b87abf89e56b7c
(cherry picked from commit b8b91e4)

Fixes #26303

@fmeum fmeum requested a review from a team as a code owner June 15, 2025 17:37
@fmeum fmeum requested a review from meteorcloudy June 15, 2025 17:38
@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Jun 15, 2025
The Bash libraries in `@bazel_tools` are replaced with aliases to `@rules_shell//shell/runfiles`.

This requires skipping load visibility checks for resolved WORKSPACE files, which are going away anyway.

Closes bazelbuild#24219.

PiperOrigin-RevId: 727843225
Change-Id: I00744bd30c637cae450d63b859b87abf89e56b7c
(cherry picked from commit b8b91e4)
@fmeum
Copy link
Collaborator Author

fmeum commented Jun 15, 2025

@meteorcloudy This fixes https://bazelbuild.slack.com/archives/CA31HN1T3/p1749919310099609, which you can observe on Bazel itself.

@meteorcloudy
Copy link
Member

@fmeum Can you take a look at the test failure? And to be sure, this isn't a breaking change for end users, right?

@fmeum
Copy link
Collaborator Author

fmeum commented Jun 16, 2025

@fmeum Can you take a look at the test failure? And to be sure, this isn't a breaking change for end users, right?

Yes, the new library should be a drop-in replacement, no changes required to init code or deps.

@meteorcloudy meteorcloudy enabled auto-merge June 16, 2025 12:14
auto-merge was automatically disabled June 16, 2025 12:16

Head branch was pushed to by a user without write access

@fmeum
Copy link
Collaborator Author

fmeum commented Jun 16, 2025

@meteorcloudy CI should be fixed now, had to update workspace_deps.bzl as well.

@fmeum fmeum requested a review from meteorcloudy June 16, 2025 12:17
@meteorcloudy meteorcloudy enabled auto-merge June 16, 2025 12:27
@meteorcloudy meteorcloudy added this pull request to the merge queue Jun 16, 2025
Merged via the queue into bazelbuild:release-8.3.0 with commit 92ab2bc Jun 16, 2025
46 checks passed
@github-actions github-actions bot removed the awaiting-review PR is awaiting review from an assigned reviewer label Jun 16, 2025
@fmeum fmeum deleted the release-8.3.0 branch June 16, 2025 13:49
@meteorcloudy
Copy link
Member

@fmeum @Wyverald So, looks like this is a breaking change we had to rollback? #26365 (comment)

@Wyverald
Copy link
Member

Yes, I'm preparing the PR.

Wyverald added a commit that referenced this pull request Jun 24, 2025
This reverts commit 92ab2bc.

Causes breakages downstream. We'll revert this for 8.x, and leave it in for 9.0.
Wyverald added a commit that referenced this pull request Jun 24, 2025
This reverts commit 92ab2bc.

Causes breakages downstream. We'll revert this for 8.x, and leave it in for 9.0.
iancha1992 pushed a commit that referenced this pull request Jun 24, 2025
…6304)" (#26372)

This reverts commit 92ab2bc.

Causes breakages downstream. We'll revert this for 8.x, and leave it in
for 9.0.
iancha1992 pushed a commit to iancha1992/bazel that referenced this pull request Jun 25, 2025
…zelbuild#26304)" (bazelbuild#26372)

This reverts commit 92ab2bc.

Causes breakages downstream. We'll revert this for 8.x, and leave it in
for 9.0.
iancha1992 pushed a commit to iancha1992/bazel that referenced this pull request Jun 25, 2025
…zelbuild#26304)" (bazelbuild#26372)

This reverts commit 92ab2bc.

Causes breakages downstream. We'll revert this for 8.x, and leave it in
for 9.0.
github-merge-queue bot pushed a commit that referenced this pull request Jun 26, 2025
…6304)" (#26372) (#26381)

This reverts commit
92ab2bc.

Causes breakages downstream. We'll revert this for 8.x, and leave it in
for 9.0.

Commit
add421c

Co-authored-by: Xùdōng Yáng <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants