-
Notifications
You must be signed in to change notification settings - Fork 4.3k
[8.3.0] Move Bash runfiles libraries out of Bazel #26304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The Bash libraries in `@bazel_tools` are replaced with aliases to `@rules_shell//shell/runfiles`. This requires skipping load visibility checks for resolved WORKSPACE files, which are going away anyway. Closes bazelbuild#24219. PiperOrigin-RevId: 727843225 Change-Id: I00744bd30c637cae450d63b859b87abf89e56b7c (cherry picked from commit b8b91e4)
@meteorcloudy This fixes https://bazelbuild.slack.com/archives/CA31HN1T3/p1749919310099609, which you can observe on Bazel itself. |
@fmeum Can you take a look at the test failure? And to be sure, this isn't a breaking change for end users, right? |
@fmeum Can you take a look at the test failure? And to be sure, this isn't a breaking change for end users, right? Yes, the new library should be a drop-in replacement, no changes required to init code or deps. |
Head branch was pushed to by a user without write access
@meteorcloudy CI should be fixed now, had to update |
92ab2bc
@fmeum @Wyverald So, looks like this is a breaking change we had to rollback? #26365 (comment) |
Yes, I'm preparing the PR. |
This reverts commit 92ab2bc. Causes breakages downstream. We'll revert this for 8.x, and leave it in for 9.0.
This reverts commit 92ab2bc. Causes breakages downstream. We'll revert this for 8.x, and leave it in for 9.0.
…zelbuild#26304)" (bazelbuild#26372) This reverts commit 92ab2bc. Causes breakages downstream. We'll revert this for 8.x, and leave it in for 9.0.
…zelbuild#26304)" (bazelbuild#26372) This reverts commit 92ab2bc. Causes breakages downstream. We'll revert this for 8.x, and leave it in for 9.0.
The Bash libraries in
@bazel_tools
are replaced with aliases to@rules_shell//shell/runfiles
.This requires skipping load visibility checks for resolved WORKSPACE files, which are going away anyway.
Closes #24219.
PiperOrigin-RevId: 727843225
Change-Id: I00744bd30c637cae450d63b859b87abf89e56b7c
(cherry picked from commit b8b91e4)
Fixes #26303