Prepare for the flip of -DBAZEL_TRACK_SOURCE_DIRECTORIES

Preparation for #25870

Closes #26698.

PiperOrigin-RevId: 792236653
Change-Id: Iaf10cc32c4938987a6afef1b73081666963435b2

Author: fmeum

src/main/java/com/google/devtools/build/lib/skyframe/ArtifactFunction.java

@@ -342,19 +342,14 @@ private SkyValue createSourceValue(Artifact artifact, Environment env)
           throw new ArtifactFunctionException(
               SourceArtifactException.create(artifact, e), Transience.PERSISTENT);
         case INCONSISTENT_FILESYSTEM:
+        case DETAILED_IO_EXCEPTION:
           throw new ArtifactFunctionException(
               SourceArtifactException.create(artifact, e), Transience.TRANSIENT);
         case GENERATED_PATH_CONFLICT:
           throw new IllegalStateException(
               String.format(
                   "Generated conflict in source tree: %s %s %s", artifact, fileValue, request),
               e);
-        // TODO: b/7075837 - This code path is possible when BAZEL_TRACK_SOURCE_DIRECTORIES is set.
-        case DETAILED_IO_EXCEPTION:
-          throw new IllegalStateException(
-              String.format(
-                  "%s: %s %s %s", e.getCause().getMessage(), artifact, fileValue, request),
-              e);
       }
       throw new IllegalStateException("Can't get here", e);
     }

src/main/java/com/google/devtools/build/lib/skyframe/TrackSourceDirectoriesFlag.java

@@ -15,10 +15,10 @@
 
 /**
  * A flag to enable / disable tracking of source directories. Uses a system property which can be
- * set via a startup flag. The intention is for this code to be temporary, so I didn't want to add
- * a permanent flag to startup options (and there's already --host_jvm_args, which we can use to
- * roll this out). The flag affects Skyframe dependencies, so it needs to clear the Skyframe graph -
- * the easiest way to do that is to restart the server, which is done when --host_jvm_args changes.
+ * set via a startup flag. The intention is for this code to be temporary, so I didn't want to add a
+ * permanent flag to startup options (and there's already --host_jvm_args, which we can use to roll
+ * this out). The flag affects Skyframe dependencies, so it needs to clear the Skyframe graph - the
+ * easiest way to do that is to restart the server, which is done when --host_jvm_args changes.
  */
 public class TrackSourceDirectoriesFlag {
   private static final boolean TRACK_SOURCE_DIRECTORIES;
@@ -32,6 +32,5 @@ public static boolean trackSourceDirectories() {
   }
 
   // Private constructor to prevent instantiation.
-  private TrackSourceDirectoriesFlag() {
-  }
+  private TrackSourceDirectoriesFlag() {}
 }

src/test/java/com/google/devtools/build/lib/buildtool/BUILD

@@ -201,6 +201,7 @@ java_test(
 java_test(
     name = "DirectoryArtifactWarningTest",
     srcs = ["DirectoryArtifactWarningTest.java"],
+    jvm_flags = ["-DBAZEL_TRACK_SOURCE_DIRECTORIES=0"],
     tags = [
         "no_windows",
     ],