Rename CcInfo#transitive_native_libraries to _legacy_transitive_native_libraries

This is needed to convert CcInfo to Starlark without causing a major regression.

Mark the field as legacy, because we'll need to eventually clean it up.
Upgrade rules_java, that support both old and new field location.

PiperOrigin-RevId: 792196604
Change-Id: I1b26336b6f234bd3cb123c213e68daee19c2e50f

Author: comius

MODULE.bazel

@@ -26,7 +26,7 @@ bazel_dep(name = "grpc", version = "1.73.1", repo_name = "com_github_grpc_grpc")
 bazel_dep(name = "platforms", version = "1.0.0")
 bazel_dep(name = "protobuf", version = "31.1", repo_name = "com_google_protobuf")
 bazel_dep(name = "rules_graalvm", version = "0.11.1")
-bazel_dep(name = "rules_java", version = "8.14.0")
+bazel_dep(name = "rules_java", version = "8.15.0")
 bazel_dep(name = "rules_jvm_external", version = "6.5")
 bazel_dep(name = "rules_license", version = "1.0.0")
 bazel_dep(name = "rules_pkg", version = "1.0.1")

MODULE.bazel.lock

@@ -38,7 +38,7 @@ use_repo(buildozer_binary, "buildozer_binary")
 # Dependencies used to auto-load removed symbols and rules from Bazel (due to Starlarkification)
 # See also:  --incompatible_autoload_externally, AutoloadSymbols
 bazel_dep(name = "protobuf", version = "31.1", repo_name = "com_google_protobuf")
-bazel_dep(name = "rules_java", version = "8.14.0")
+bazel_dep(name = "rules_java", version = "8.15.0")
 bazel_dep(name = "rules_cc", version = "0.1.2")
 bazel_dep(name = "rules_python", version = "1.3.0")
 bazel_dep(name = "rules_shell", version = "0.3.0")

src/MODULE.tools

@@ -85,8 +85,7 @@ public StarlarkInfo getCcDebugInfoContextFromStarlark(StarlarkThread thread)
   }
 
   @Override
-  public Depset getCcTransitiveNativeLibraries(StarlarkThread thread) throws EvalException {
-    CcModule.checkPrivateStarlarkificationAllowlist(thread);
+  public Depset getCcTransitiveNativeLibraries() {
     return Depset.of(
         StarlarkInfo.class,
         CcNativeLibraryInfo.getTransitiveCcNativeLibraries(getCcNativeLibraryInfo()));

src/main/java/com/google/devtools/build/lib/rules/cpp/CcInfo.java

@@ -62,11 +62,11 @@ public interface CcInfoApi<FileT extends FileApi> extends StructApi {
       throws EvalException;
 
   @StarlarkMethod(
-      name = "transitive_native_libraries",
+      name = "_legacy_transitive_native_libraries",
       documented = false,
-      doc = "Returns a depset of the transitive native libraries",
-      useStarlarkThread = true)
-  Depset getCcTransitiveNativeLibraries(StarlarkThread thread) throws EvalException;
+      structField = true,
+      doc = "Returns a depset of the transitive native libraries")
+  Depset getCcTransitiveNativeLibraries() throws EvalException;
 
   /** The provider implementing this can construct CcInfo objects. */
   @StarlarkBuiltin(

src/main/java/com/google/devtools/build/lib/starlarkbuildapi/cpp/CcInfoApi.java

@@ -345,13 +345,13 @@ def _merge_cc_infos(*, direct_cc_infos = [], cc_infos = []):
         direct_cc_compilation_contexts.append(cc_info.compilation_context)
         cc_linking_contexts.append(cc_info.linking_context)
         cc_debug_info_contexts.append(cc_info.debug_context())
-        transitive_native_cc_libraries.append(cc_info.transitive_native_libraries())
+        transitive_native_cc_libraries.append(cc_info._legacy_transitive_native_libraries)
 
     for cc_info in cc_infos:
         cc_compilation_contexts.append(cc_info.compilation_context)
         cc_linking_contexts.append(cc_info.linking_context)
         cc_debug_info_contexts.append(cc_info.debug_context())
-        transitive_native_cc_libraries.append(cc_info.transitive_native_libraries())
+        transitive_native_cc_libraries.append(cc_info._legacy_transitive_native_libraries)
 
     return CcInfo(
         compilation_context = cc_common_internal.merge_compilation_contexts(compilation_contexts = direct_cc_compilation_contexts, non_exported_compilation_contexts = cc_compilation_contexts),

src/main/starlark/builtins_bzl/common/cc/cc_common.bzl

@@ -297,7 +297,7 @@ def _get_dynamic_library_for_runtime_or_none(library, linking_statically):
     return library.dynamic_library
 
 def _collect_native_cc_libraries(deps, libraries):
-    transitive_libraries = [dep[CcInfo].transitive_native_libraries() for dep in deps if CcInfo in dep]
+    transitive_libraries = [dep[CcInfo]._legacy_transitive_native_libraries for dep in deps if CcInfo in dep]
     return CcNativeLibraryInfo(libraries_to_link = depset(direct = libraries, transitive = transitive_libraries))
 
 def _build_linking_context_from_libraries(ctx, libraries):