Skip to content

Schema is split to request and response parts #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

matllubos
Copy link

No description provided.

@matllubos matllubos changed the title Schema is splitted to request and response parts Schema is split to request and response parts Jul 10, 2018
@matllubos
Copy link
Author

I think that for swagger 2.0 schema should be split to request and response because there is missing writeOnly value (added in 3.0). Result swagger file is invalid if serializer contains write_only or read_only fields

@matllubos
Copy link
Author

I will try to fix test in the next days

@matllubos matllubos force-pushed the SplitSchemaToRequestAndResponse branch from f52fb3f to 1d5de34 Compare July 10, 2018 12:52
@sobolevn
Copy link

+1 this is totally required.
@matllubos thanks!

Copy link
Owner

@axnsan12 axnsan12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bit invasive with adding arguments to all inspector methods. It's also not very robust - one might also want to generate different schemas according to request method (e.g. all fields optional for PATCH).

The behaviour would also have to be behind a setting since not every use case might want this.

@JoelLefkowitz JoelLefkowitz changed the base branch from master to 1.21.x July 17, 2022 17:20
@JoelLefkowitz JoelLefkowitz added the 1.21.x Release target in 1.21.x label Jul 17, 2022
@JoelLefkowitz
Copy link
Collaborator

@matllubos thanks for the time put into this PR. Could you bring the branch up to date with the 1.21.x branch or enable me to push to it?

@JoelLefkowitz JoelLefkowitz added 1.22.x Release target in 1.22.x and removed 1.21.x Release target in 1.21.x labels Jul 17, 2022
@JoelLefkowitz JoelLefkowitz deleted the branch axnsan12:master October 17, 2024 11:55
@JoelLefkowitz JoelLefkowitz reopened this Oct 17, 2024
@JoelLefkowitz JoelLefkowitz changed the base branch from 1.21.x to master October 17, 2024 12:08
@JoelLefkowitz JoelLefkowitz added the bug Bug report label Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.22.x Release target in 1.22.x bug Bug report
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants