-
Notifications
You must be signed in to change notification settings - Fork 440
Schema is split to request and response parts #164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
I think that for swagger 2.0 schema should be split to request and response because there is missing writeOnly value (added in 3.0). Result swagger file is invalid if serializer contains write_only or read_only fields |
I will try to fix test in the next days |
f52fb3f
to
1d5de34
Compare
+1 this is totally required. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a bit invasive with adding arguments to all inspector methods. It's also not very robust - one might also want to generate different schemas according to request method (e.g. all fields optional for PATCH).
The behaviour would also have to be behind a setting since not every use case might want this.
@matllubos thanks for the time put into this PR. Could you bring the branch up to date with the 1.21.x branch or enable me to push to it? |
No description provided.