Skip to content

Build go in Docker#85

Merged
simonmarty merged 48 commits intoaws:mainfrom
simonmarty:docker-build
Jun 23, 2025
Merged

Build go in Docker#85
simonmarty merged 48 commits intoaws:mainfrom
simonmarty:docker-build

Conversation

@simonmarty
Copy link
Contributor

@simonmarty simonmarty commented May 13, 2022 •
edited
Loading

Issue #, if available:

Description of changes: Build go in Docker instead of using the go environment of the Host OS.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Testing

kubectl apply -f ../tests/BasicTestMountSPC.yaml
Warning: secrets-store.csi.x-k8s.io/v1alpha1 is deprecated. Use secrets-store.csi.x-k8s.io/v1 instead.
secretproviderclass.secrets-store.csi.x-k8s.io/basic-test-mount-spc configured
❯ kubectl apply -f ../tests/BasicTestMountSPC.yaml
secretproviderclass.secrets-store.csi.x-k8s.io/basic-test-mount-spc configured
❯ kubectl apply -f ../tests/BasicTestMount.yaml
pod/basic-test-mount configured
❯ kubectl exec basic-test-mount -- cat /mnt/secrets-store/SecretsManagerTest1
SecretsManagerTest1Value

@simonmarty simonmarty added the enhancement New feature or request label May 13, 2022
@simonmarty simonmarty requested a review from joebaro May 13, 2022 23:58
@simonmarty simonmarty self-assigned this May 13, 2022
@simonmarty simonmarty enabled auto-merge (squash) May 13, 2022 23:59
@simonmarty simonmarty requested review from smobyrne and yanwum May 14, 2022 00:02
@simonmarty simonmarty added the dependencies Pull requests that update a dependency file label May 14, 2022
@simonmarty simonmarty changed the title Upgrade to CSI Driver v1.1.2, Go v1.18 Build go in docker, Upgrade to CSI Driver v1.1.2, Go v1.18 Jun 1, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jul 17, 2022 •
edited
Loading

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@simonmarty simonmarty force-pushed the main branch 2 times, most recently from 0f92579 to eed04c5 Compare July 17, 2022 22:26
@simonmarty simonmarty changed the title Build go in docker, Upgrade to CSI Driver v1.1.2, Go v1.18 Build go in docker, Upgrade to CSI Driver v1.2.2, Go v1.18 Jul 17, 2022
@simonmarty simonmarty changed the title Build go in docker, Upgrade to CSI Driver v1.2.2, Go v1.18 Build go in docker, Upgrade CSI Driver and Go version Aug 30, 2022
@simonmarty simonmarty requested a review from danmancuso August 30, 2022 23:10
@simonmarty
Copy link
Contributor Author

simonmarty commented Sep 19, 2022

Experiencing bugs when @danmancuso tried to deploy to an ARM64 cluster. Investigating.

@simonmarty simonmarty force-pushed the main branch 2 times, most recently from 9021d72 to 489f792 Compare September 21, 2022 00:21
@simonmarty simonmarty disabled auto-merge May 2, 2025 19:50
@ThirdEyeSqueegee
Copy link
Member

ThirdEyeSqueegee commented Jun 23, 2025

Confirmed working on ARM clusters.

@simonmarty simonmarty requested review from rstevens011 and removed request for joebaro June 23, 2025 21:33
rstevens011
rstevens011 approved these changes Jun 23, 2025
View reviewed changes
Copy link

@rstevens011 rstevens011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 🚢 it

@simonmarty simonmarty merged commit 8fa0a04 into aws:main Jun 23, 2025
2 checks passed
@simonmarty simonmarty deleted the docker-build branch June 23, 2025 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rstevens011 rstevens011 rstevens011 approved these changes

@ThirdEyeSqueegee ThirdEyeSqueegee ThirdEyeSqueegee approved these changes

Assignees

@simonmarty simonmarty

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@simonmarty @codecov-commenter @ThirdEyeSqueegee @rstevens011