Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #561 +/- ##
==========================================
- Coverage 61.56% 61.49% -0.08%
==========================================
Files 11 12 +1
Lines 752 748 -4
==========================================
- Hits 463 460 -3
+ Misses 274 270 -4
- Partials 15 18 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ThirdEyeSqueegee
added
the
safe-to-test
ThirdEyeSqueegee
force-pushed
the
tokens
branch
from
1f54410 to
9d3e691
Compare
github-actions
bot
removed
the
safe-to-test
ThirdEyeSqueegee
added
safe-to-test
github-actions
bot
removed
the
safe-to-test
ThirdEyeSqueegee
added
the
safe-to-test
simonmarty
added
safe-to-test
simonmarty
requested changes
Feb 3, 2026
| ) | ||
| } | ||
|
|
||
| if err != nil { |
| for _, tt := range tests { | ||
| t.Run(tt.name, func(t *testing.T) { | ||
| k8sClient := fake.NewClientset().CoreV1() | ||
| timeout := 100 * time.Millisecond |
| } | ||
|
|
||
| pod_identity := PodIdentityCredentialProvider{ | ||
| klog.V(2).Infof("Pod Identity token obtained for audience %q", podIdentityAudience) |
Contributor
There was a problem hiding this comment.
Why is the .V(2) needed here?
| case "ipv6": | ||
| return "ipv6" | ||
| default: | ||
| return "auto" // Default to auto for invalid preferences |
Contributor
There was a problem hiding this comment.
Why was the comment removed here? Was it inaccurate?
|
|
||
| if preference == "auto" || preference == "ipv4" { | ||
| config, err := p.getConfigWithEndpoint(ctx, podIdentityAgentEndpointIPv4) | ||
| cfg, err := p.getConfigWithEndpoint(ctx, podIdentityAgentEndpointIPv4) |
Contributor
There was a problem hiding this comment.
Why was this variable renamed?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#400, #422
Description of changes:
Implement CSI Token Requests
Testing: e2e tested by hand (rotation not yet tested, awaiting upstream driver release)
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.