Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #556 +/- ##
==========================================
+ Coverage 60.10% 61.56% +1.46%
==========================================
Files 11 11
Lines 762 752 -10
==========================================
+ Hits 458 463 +5
+ Misses 287 274 -13
+ Partials 17 15 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Please add some info reg the bug in the old User-Agent middleware logic. |
|
Could we explore using AppID for configuring the user agent: https://pkg.go.dev/github.com/aws/aws-sdk-go-v2/config |
Maybe, as long as it doesn't risk getting overwritten too easily by accident by customers. |
|
Pivoted to using AppID a couple commits ago @simonmarty. Plz review whenever you can 😁 |
|
Cursory look suggests that using AppID does what Angad was proposing in a earlier revision: https://github.com/aws/aws-sdk-go-v2/blob/de58dc6cdc4c35ac4687d53cff781a6027a0f52f/codegen/smithy-aws-go-codegen/src/main/java/software/amazon/smithy/aws/go/codegen/AwsClientUserAgent.java#L79-L91 |
i-am-SR
left a comment
There was a problem hiding this comment.
The implementation has changed since the last review. Please ensure we have validated the updated UA value in the service logs.
|
Experiencing some weirdness with the IRSA integ tests failing to create EKS clusters. I'm going to override the approvals. |
Issue #, if available:
N/A
Description of changes:
The old User-Agent middleware logic was bugged causing the provider and add-on versions to not show up in service logs. This was due to our custom middleware adding an entirely new header instead of modifying the existing UserAgent header which was never ingested on the service side.
middlewareimport to fix thisExample of UserAgent after this change (from service log):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.