Skip to content

Add support for EKS Pod Identity#416

Merged
tongshen-stephanie merged 14 commits intoaws:mainfrom
tongshen-stephanie:main
Feb 10, 2025
Merged

Add support for EKS Pod Identity#416
tongshen-stephanie merged 14 commits intoaws:mainfrom
tongshen-stephanie:main

Conversation

@tongshen-stephanie
Copy link
Contributor

@tongshen-stephanie tongshen-stephanie commented Jan 8, 2025

Issue #, if available: Closes #300

Description of changes:
Introduce an optional parameter usePodIdentity to support EKS Pod Identity

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@tongshen-stephanie tongshen-stephanie requested a review from a team as a code owner January 8, 2025 17:53
@tongshen-stephanie tongshen-stephanie changed the title Add support for Pod Idenity Add support for EKS Pod Identity Jan 8, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 68.42105% with 72 lines in your changes missing coverage. Please review.

Project coverage is 52.62%. Comparing base (be94dd0) to head (4dd8774).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
...ntial_provider/pod_identity_credential_provider.go 70.43% 28 Missing and 6 partials ⚠️
auth/auth.go 31.42% 23 Missing and 1 partial ⚠️
credential_provider/irsa_credential_provider.go 83.33% 10 Missing ⚠️
provider/parameter_store_provider.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #416      +/-   ##
==========================================
+ Coverage   49.67%   52.62%   +2.94%     
==========================================
  Files           9       11       +2     
  Lines         781      952     +171     
==========================================
+ Hits          388      501     +113     
- Misses        383      436      +53     
- Partials       10       15       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

},
}

// Use the K8s API to fetch the token from the OIDC provider.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case there likely will not be an OIDC provider.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated in commit 4d4df72

@tongshen-stephanie tongshen-stephanie merged commit 8244505 into aws:main Feb 10, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pod Identity Association support

5 participants