(feat): Add context selector to prompt input #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added contextCommands to store model updated prompt input text view with dynamic span
added bold wrapping for escapedPrompt to prompt rendering updated data models
imykhai
approved these changes
Jun 20, 2024
ege0zcan
reviewed
Jun 27, 2024
| * */ | ||
| cancelButtonWhenLoading?: boolean; | ||
| /** | ||
| * Quick Action commands to show when user hits / to the input initially | ||
| */ | ||
| quickActionCommands?: QuickActionCommandGroup[]; | ||
| /** | ||
| * Context commands to show when user hits @ to the input any point | ||
| */ | ||
| contextCommands?: QuickActionCommandGroup[]; |
There was a problem hiding this comment.
nit: maybe it is time to think of a more generic name for these given they are now shared, something like CommandGroup
| mynahUI.updateStore('tab-1', { | ||
| contextCommands: [ | ||
| { | ||
| groupName: 'Metion code', |
| --- | ||
|
|
||
| ## ChatPrompt | ||
| This is the object model which will be send along with the `onChatPrompt` event. |
| @@ -101,7 +101,7 @@ export const QuickActionCommands:QuickActionCommandGroup[] = [ | |||
| }, | |||
| ], | |||
| }, | |||
| ]; | |||
| ] as QuickActionCommandGroup[]; | |||
There was a problem hiding this comment.
nit: why is this as QuickActionCommandGroup[] needed, doesn't line 12 already ensure the type?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Exactly like the quick action commands selector, a context selector should be implemented into the prompt input field. But unlike the quick action commands, it can be picked multiple times and should be written inside the prompt text. It should also send the selected context items in an additional attribute in the
promptobject.The available context items should be provided through the data model like the QuickAction commands but in a new attribute field.
We want to allow users to specify a target for the context like
workspaceor in the futurefileorfolder.Solution
contextCommandsand accepts an array ofQuickActionCommandGroup@character insertion and enables the overlay picker for the provided context items if there is any.@) and removes the whole word/mention.contextCommandsaddition.License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.