Skip to content

Dogusata/add code diff to syntax highlighter and file description tooltip #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

dogusata
Copy link
Collaborator

@dogusata dogusata commented Jun 13, 2024

Problem

  • SyntaxHighlighter should support diff view. Since it is already there with prism.js it has to be enabled.
  • FileItem component should support markdown tooltips
  • Sometimes tooltips exceeding the screen edges

Solution

  • Updated SyntaxHighlighter component to support diff view too
  • Added tooltip ability to FileItem component
  • Fixed tooltip edge bleeding issue.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

dogusata added 4 commits June 13, 2024 11:54
added description field which shows a tooltip for file details
added file detail description tooltip example
updated styles to support highlighed diff-view
updated styles to support clicks together with hover on file view
updated file item tooltip delay duration
updated file item example
@dogusata dogusata requested a review from a team as a code owner June 13, 2024 13:38
removed commented imports
updated example app
kmile
kmile previously approved these changes Jun 17, 2024
@dogusata dogusata merged commit 301163b into main Jun 17, 2024
1 check passed
@ege0zcan ege0zcan deleted the dogusata/add-code-diff-to-syntax-highlighter-and-file-description-tooltip branch June 21, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants