Skip to content

feat: make target for code gen with pr check#10

Merged
ndbaker1 merged 1 commit intomainfrom
generate
May 17, 2025
Merged

feat: make target for code gen with pr check#10
ndbaker1 merged 1 commit intomainfrom
generate

Conversation

@ndbaker1
Copy link
Contributor

@ndbaker1 ndbaker1 commented May 15, 2025

Issue #, if available:

Description of changes:

working on PR workflow checks for standardizing chart contributions

Testing Done:

make generate

tested bad commit: https://github.com/aws/eks-node-monitoring-agent/actions/runs/15036393319/job/42258862624?pr=10#step:3:37

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ndbaker1 ndbaker1 force-pushed the generate branch 3 times, most recently from ab8ab0c to a37f23e Compare May 15, 2025 04:08
Copy link

@wwvela wwvela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ndbaker1 ndbaker1 merged commit 5a02558 into main May 17, 2025
2 checks passed
@ndbaker1 ndbaker1 deleted the generate branch May 17, 2025 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants