Optimize ebpf programs

[Pavani-Panakanti]

Issue #, if available:
Updating bpf program files to follow best practices

Description of changes:

• functions should be always inline
• number of arguments to a func should be less than 5
• arguments should be passed as pointers than values

Testing
Cyclonus tests passed for both v4 and v6 with standard and strict mode

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

[Copilot]

Pull Request Overview

This PR optimizes the eBPF programs by updating function signatures and argument usage to follow best practices. Key changes include:

• Changing functions from static inline to static __always_inline.
• Reducing function arguments by removing the ip and l4_dst_port parameters.
• Updating protocol and port comparisons to use flow_key values.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File	Description
pkg/ebpf/c/tc.v6ingress.bpf.c	Updated evaluateByLookUp: changed signature and replaced ip/l4_dst_port usage with flow_key values.
pkg/ebpf/c/tc.v6egress.bpf.c	Updated evaluateByLookUp: changed signature and replaced ip/l4_dst_port usage with flow_key values.
pkg/ebpf/c/tc.v4ingress.bpf.c	Updated evaluateByLookUp: changed signature and replaced ip/l4_dst_port usage with flow_key values.
pkg/ebpf/c/tc.v4egress.bpf.c	Updated evaluateByLookUp: changed signature and replaced ip/l4_dst_port usage with flow_key values.

Comments suppressed due to low confidence (4)

pkg/ebpf/c/tc.v6ingress.bpf.c:101

• The update to remove the ip and l4_dst_port parameters aligns with reducing function complexity; please verify that flow_key provides all the needed protocol and port information in every use case.

static __always_inline int evaluateByLookUp(struct keystruct trie_key, struct conntrack_key flow_key, struct pod_state *pst, struct data_t evt) {

pkg/ebpf/c/tc.v6egress.bpf.c:99

• The removal of the ip and l4_dst_port parameters simplifies the function interface; please ensure that replacing these with flow_key values consistently meets the logic requirements.

static __always_inline int evaluateByLookUp(struct keystruct trie_key, struct conntrack_key flow_key, struct pod_state *pst, struct data_t evt) {

pkg/ebpf/c/tc.v4ingress.bpf.c:98

• The updated signature removes unused parameters, which is a good improvement; please confirm that the flow_key fully substitutes the protocol and port values originally provided by ip and l4_dst_port.

static __always_inline int evaluateByLookUp(struct keystruct trie_key, struct conntrack_key flow_key, struct pod_state *pst, struct data_t evt) {

pkg/ebpf/c/tc.v4egress.bpf.c:98

• Removing the ip and l4_dst_port parameters adheres to the best practice of limiting function arguments; please ensure that using flow_key for protocol and destination port comparison is adequate for all intended packet handling scenarios.

static __always_inline int evaluateByLookUp(struct keystruct trie_key, struct conntrack_key flow_key, struct pod_state *pst, struct data_t evt) {