Skip to content

Add --ignore-loopback flag to exclude self-referential pod connections, updating cyclonus. #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yash97
Copy link
Contributor

@yash97 yash97 commented Oct 8, 2024

Issue #, if available:

Description of changes:

This PR introduces the --ignore-loopback=true parameter to exclude test cases where a network policy blocks a pod's connection to itself. Our network policy agent attaches tc cls hooks on the host veth side, not on the container's loopback interface. Consequently, self-referential connection tests may fail, as they don't accurately reflect our agent's behavior.

This flag allows for more accurate testing by focusing on inter-pod and external communications, aligning test results with our network policy agent's actual capabilities.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@yash97 yash97 requested a review from a team as a code owner October 8, 2024 18:10
@jaydeokar
Copy link
Contributor

Can you check this against v6 too ? We also need to change the python script which we run to validate the results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants