-
Notifications
You must be signed in to change notification settings - Fork 557
security: bump fsevents to latest(SEC- 2161) #2643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2643 +/- ##
=======================================
Coverage 42.54% 42.54%
=======================================
Files 120 120
Lines 3145 3145
Branches 337 337
=======================================
Hits 1338 1338
Misses 1713 1713
Partials 94 94 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Quick note - |
Yes, it's fine. I think if everything is fine, we can merge this pr? |
Changes
fsevents
to latest (2.3.3
→^2.3.3
) inpackage.json
andpackage-lock.json
package-lock.json
to remove outdated entries and avoid conflictsReferences
Testing
npm install
completes without errorsnpm test
) — all tests passnpm run test:e2e -- --no-sandbox
) in CI environment — ChromeHeadless now starts successfullynpm run build
) and manual smoke test of Lock UIChecklist
npm run lint
,npm run test:es-check
)