Skip to content

docs: fix readme examples #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 30, 2021
Merged

docs: fix readme examples #88

merged 5 commits into from
Apr 30, 2021

Conversation

jfatta
Copy link

@jfatta jfatta commented Apr 30, 2021

close #80
Also added the first one under ./examples/.

testing
image

@codecov-commenter
Copy link

codecov-commenter commented Apr 30, 2021

Codecov Report

Merging #88 (adef71f) into master (f4b59c0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #88   +/-   ##
=======================================
  Coverage   46.83%   46.83%           
=======================================
  Files           1        1           
  Lines          79       79           
=======================================
  Hits           37       37           
  Misses         30       30           
  Partials       12       12           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4b59c0...adef71f. Read the comment docs.

@jfatta jfatta marked this pull request as ready for review April 30, 2021 16:38
@jfatta jfatta requested a review from a team as a code owner April 30, 2021 16:38
Copy link
Contributor

@grounded042 grounded042 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Could we have a quick README in the http-example folder to follow the other examples?

@copland
Copy link

copland commented Apr 30, 2021

This is also more of a chore: than a fix:, no?

@jfatta
Copy link
Author

jfatta commented Apr 30, 2021

This is also more of a chore: than a fix:, no?

good point. I'd say docs:

@jfatta jfatta changed the title fix: readme examples docs: fix readme examples Apr 30, 2021
@jfatta jfatta requested a review from grounded042 April 30, 2021 17:12
Copy link
Contributor

@grounded042 grounded042 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Thanks @jfatta!

@jfatta jfatta merged commit d600c10 into master Apr 30, 2021
@jfatta jfatta deleted the fix-readme-example branch April 30, 2021 17:39
d10i pushed a commit to Hikely/go-jwt-middleware that referenced this pull request Nov 2, 2021
* fix: readme examples

* fix negroni at readme

* Update README.md

* add http example readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

example on main page doesn't run
4 participants