Skip to content

Fix GitSync Probe Validation and Refactor Redis Probe Definitions #1528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 30, 2025

Conversation

Shubham-astro
Copy link

@Shubham-astro Shubham-astro commented May 30, 2025

Problem

The deployment validation was failing with the following error:

dags.gitSync.livenessProbe: Additional property successThreshold is not allowed
dags.gitSync.readinessProbe: Additional property successThreshold is not allowed

This occurred because the schema was using the generic io.k8s.api.core.v1.Probe definition which includes successThreshold for all probe types. However, according to Kubernetes specifications:

Liveness probes: successThreshold is not allowed (always implicitly 1)
Readiness probes: successThreshold is allowed

Additionally, Redis probe configurations were hardcoded with specific properties instead of using reusable probe definitions.

Issue

https://github.com/astronomer/issues/issues/7291

Changes

  1. Created Specific Probe Definitions
    Added two new probe definitions in the schema's definitions section:

LivenessProbe: Excludes successThreshold property (Kubernetes compliant)
ReadinessProbe: Includes successThreshold property (allows configuration)

  1. Refactored Redis Probe Definitions
    Replaced hardcoded Redis probe properties with reusable probe references

@Shubham-astro Shubham-astro merged commit 84ca18c into helm-chart/v1-15-0-astro May 30, 2025
1 check passed
@Shubham-astro Shubham-astro deleted the missing-fix branch May 30, 2025 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants