Fix GitSync Probe Validation and Refactor Redis Probe Definitions #1528
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The deployment validation was failing with the following error:
This occurred because the schema was using the generic io.k8s.api.core.v1.Probe definition which includes successThreshold for all probe types. However, according to Kubernetes specifications:
Liveness probes: successThreshold is not allowed (always implicitly 1)
Readiness probes: successThreshold is allowed
Additionally, Redis probe configurations were hardcoded with specific properties instead of using reusable probe definitions.
Issue
https://github.com/astronomer/issues/issues/7291
Changes
Added two new probe definitions in the schema's definitions section:
LivenessProbe: Excludes successThreshold property (Kubernetes compliant)
ReadinessProbe: Includes successThreshold property (allows configuration)
Replaced hardcoded Redis probe properties with reusable probe references