replace manual venv removal with remove_virtualenv #15007
+14
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adjusted the error type in the match arm
zanieb
reviewed
Jul 31, 2025
|
Thank you! |
Its already covered in remove_virtualenv
|
An error is no longer properly propagated for the tools when uninstalling a not installed tool. Can reproduce it locally and will try to fix that |
self-replace is no longer needed here, since we invoke the remove_virtualenv function from uv-virtualenv. This also caused a problem that the uv_tool::Error::Io is no longer raised, but the uv_tool::Error::VirtualEnvError, when e.g. `black` is not present as a tool in the test case.
zanieb
reviewed
Aug 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
At some places the virtualenv directory was manually removed instead of using
remove_virtualenv.I also adjusted the error type.
#14985
Test Plan