-
Notifications
You must be signed in to change notification settings - Fork 315
Add an article how to implement a log handler #364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an article how to implement a log handler #364
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small wording suggestion changes, and a rework of the abstract for the article so that it doesn't include a symbol reference within it
9439d05
to
87bfbd2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor header level changes to make the levels more consistent as an article, and a suggestion to shift the "performance considerations" higher up on the article.
I'd also recommend merging #363 first, rebasing this, and then included it into the top-level page as an article reference, as without it - it'll be sort of buried beneath everything else.
# Motivation In my previous PR, I overhauled the README and the DocC catalog. While doing this I removed the guidance around how to implement a log handler. # Modifications This PR adds a DocC based guide containing the contents of the previous README guidance. # Result Guidance around log handler implementation in a modern DocC format.
87bfbd2
to
5e47710
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great
Motivation
In my previous PR, I overhauled the README and the DocC catalog. While doing this I removed the guidance around how to implement a log handler.
Modifications
This PR adds a DocC based guide containing the contents of the previous README guidance.
Result
Guidance around log handler implementation in a modern DocC format.