-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[draft] gRPC: Implement a subset of fdbcli as gRPC service #12228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
vishesh
wants to merge
1
commit into
apple:main
Choose a base branch
from
vishesh:grpc-fdbcli
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,222
−141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Result of foundationdb-pr-clang-arm on Linux CentOS 7
|
Result of foundationdb-pr-cluster-tests on Linux RHEL 9
|
Result of foundationdb-pr on Linux RHEL 9
|
Result of foundationdb-pr-clang-ide on Linux RHEL 9
|
Result of foundationdb-pr-clang on Linux RHEL 9
|
Result of foundationdb-pr on Linux RHEL 9
|
Result of foundationdb-pr-clang-arm on Linux CentOS 7
|
Result of foundationdb-pr-clang on Linux RHEL 9
|
Result of foundationdb-pr-cluster-tests on Linux RHEL 9
|
Result of foundationdb-pr-clang-ide on Linux RHEL 9
|
Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x
|
Result of foundationdb-pr-macos on macOS Ventura 13.x
|
Result of foundationdb-pr on Linux RHEL 9
|
Result of foundationdb-pr-clang-ide on Linux RHEL 9
|
Result of foundationdb-pr-clang on Linux RHEL 9
|
Result of foundationdb-pr-clang-arm on Linux CentOS 7
|
Result of foundationdb-pr-cluster-tests on Linux RHEL 9
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is work-in-progress gRPC implementation for commands offered by fdbcli. Very rough right now and mostly one-on-one translation. Requires some deduplication of code b/w fdbcli and this, timeouts, better error handling, and also changing some proto messages to be less like a command line tool system. Currently, its running along-side Coordinators, but will likely change (into its role) based on feedback and what makes sense in prod.
Service is defined by this protobuf:
https://github.com/apple/foundationdb/pull/12228/files#diff-070b97a444f31640b4abe3b3e1e3a51562742e3833e1eacc1f7ae2a57c2c2af7
The commands provided by fdbcli will move into a separate module called fdbcli_lib that can be shared b/w fdbcli and gRPC server. https://github.com/apple/foundationdb/pull/12228/files#diff-4495b8e09f804074bb8a4b714cb024ae2b457c35f8574f6f1a2c3c79f4d6e59a
The gRPC service is a wrapper around fdbcli_lib which is defined over here: https://github.com/apple/foundationdb/pull/12228/files#diff-756a2a4d10342c754688efd83b9c1d88121ad53bb7c48b16e6aea7e32eb40a9d
Currently, all the requests run on main thread.
Code-Reviewer Section
The general pull request guidelines can be found here.
Please check each of the following things and check all boxes before accepting a PR.
For Release-Branches
If this PR is made against a release-branch, please also check the following:
release-branch
ormain
if this is the youngest branch)