ZOOKEEPER-2623: Forbid OpCode.check outside OpCode.multi #2105
+161
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kezhuw
force-pushed
the
ZOOKEEPER-2623-forbid-opcode-check-outside-multi-backport-3.9
branch
2 times, most recently
from
93ee6a8 to
3b24226
Compare
kezhuw
force-pushed
the
ZOOKEEPER-2623-forbid-opcode-check-outside-multi-backport-3.9
branch
from
3b24226 to
789a5ae
Compare
kezhuw
force-pushed
the
ZOOKEEPER-2623-forbid-opcode-check-outside-multi-backport-3.9
branch
from
789a5ae to
e7d6c6d
Compare
Individual `OpCode.check` will get `UnimplementedException`. This is a squashed backport of several commits from master: 1. b31f776 (apache#1988) 2. dc99bd7 (apache#2067) 3. 66f9cc3 (apache#2104)
kezhuw
force-pushed
the
ZOOKEEPER-2623-forbid-opcode-check-outside-multi-backport-3.9
branch
from
e7d6c6d to
b19e75c
Compare
|
I am going to merge this as it is a simple backport now. |
tisonkun
approved these changes
Aug 12, 2024
|
Go for it. |
|
@kezhuw Ah, here's the 3.9 patch! |
kezhuw
deleted the
ZOOKEEPER-2623-forbid-opcode-check-outside-multi-backport-3.9
branch
sehaj-sandhu
pushed a commit
to acceldata-io/zookeeper
that referenced
this pull request
May 23, 2025
…pache#2105) Individual `OpCode.check` will get `UnimplementedException`. This is a squashed backport of several commits from master: 1. b31f776 (apache#1988) 2. dc99bd7 (apache#2067) 3. 66f9cc3 (apache#2104)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Individual
OpCode.checkwill getUnimplementedException.This is a squashed backport of several commits from master: