ZOOKEEPER-4549: ProviderRegistry may be repeatedly initialized #1888
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lanicc |
|
|
@maoling yeah..That's a mistake since this is not a singleton pattern. I think we should revert this change. |
Each zkServer should hold a single ProviderRegistry object instead of sharing one. It's right? @maoling @tisonkun |
|
in tests we start multiple ZK servers. |
|
@maoling How should we deal with this problem? |
rishabhtalim
approved these changes
Jul 5, 2022
anurag-harness
pushed a commit
to anurag-harness/zookeeper
that referenced
this pull request
Jan 13, 2023
We run two ZooKeeperServerEmbedded in one JVM and find that ProviderRegistry was initialized repeatedly. Author: lanicc <[email protected]> Reviewers: Enrico Olivelli <[email protected]>, tison <[email protected]>, maoling <[email protected]> Closes apache#1888 from lanicc/ZOOKEEPER-4549
anurag-harness
added a commit
to anurag-harness/zookeeper
that referenced
this pull request
Jan 13, 2023
We run two ZooKeeperServerEmbedded in one JVM and find that ProviderRegistry was initialized repeatedly. Author: lanicc <[email protected]> Reviewers: Enrico Olivelli <[email protected]>, tison <[email protected]>, maoling <[email protected]> Closes apache#1888 from lanicc/ZOOKEEPER-4549 Co-authored-by: lanicc <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We run two ZooKeeperServerEmbedded in one JVM and find that ProviderRegistry was initialized repeatedly.