Skip to content

Remove Unnecessary semicolons in prototype.js. Muse bug bash 2020. #1473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove Unnecessary semicolons in prototype.js. Muse bug bash 2020. #1473

wants to merge 1 commit into from
+5 −5

Conversation

mahitab-farid
Copy link

eolivelli
eolivelli approved these changes Oct 1, 2020
View reviewed changes
Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomMD
Copy link

TomMD commented Oct 5, 2020

@mahitab-farid Thank you for the fixes! The Zookeeper project has a process for organizing contributions (see https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute). Could you open a JIRA ticket and update this PR? They'd like to accept these fixes but the process is really helpful to discussion and workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctubbsii ctubbsii ctubbsii approved these changes

@eolivelli eolivelli eolivelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mahitab-farid @TomMD @ctubbsii @eolivelli @m-farid