-
Notifications
You must be signed in to change notification settings - Fork 15.3k
fix(dashboard): adds dependent filters select first value fixes #34137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ObservabilityTeam
wants to merge
4
commits into
apache:master
Choose a base branch
from
ObservabilityTeam:fix/dependent-filter-select-first-fix
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix(dashboard): adds dependent filters select first value fixes #34137
ObservabilityTeam
wants to merge
4
commits into
apache:master
from
ObservabilityTeam:fix/dependent-filter-select-first-fix
+158
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review by Korbit AI
Korbit automatically attempts to detect when you fix issues in new commits.
Category | Issue | Status |
---|---|---|
Improve cascade filter check comment ▹ view | 🧠 Not in standard | |
Parent Filter Value Count Uses Default Instead of Current State ▹ view | 🧠 Not in scope | |
Inefficient JSON.stringify in Dependency Array ▹ view | 🧠 Not in scope | |
Filter state not updating after parent filter changes ▹ view | 🧠 Not in scope | |
Incomplete data change detection ▹ view | 🧠 Incorrect | |
Inaccurate Time Range Dependency Counting ▹ view | 🧠 Incorrect |
Files scanned
File Path | Reviewed |
---|---|
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterValue.tsx | ✅ |
superset-frontend/src/filters/components/Select/SelectFilterPlugin.tsx | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Check out our docs on how you can make Korbit work best for you and your team.
superset-frontend/src/filters/components/Select/SelectFilterPlugin.tsx
Outdated
Show resolved
Hide resolved
superset-frontend/src/filters/components/Select/SelectFilterPlugin.tsx
Outdated
Show resolved
Hide resolved
...set-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterValue.tsx
Outdated
Show resolved
Hide resolved
...set-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterValue.tsx
Outdated
Show resolved
Hide resolved
...set-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterValue.tsx
Show resolved
Hide resolved
* adds a fix for correctly selecting first value of a dependent filter * adds a fix for automatically selecting the correct dependent filter value on changing parent filter value * adds dependent filters fix support for time range filter
da85911
to
6e2dba4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dashboard:native-filters
Related to the native filters of the Dashboard
dashboard
Namespace | Anything related to the Dashboard
size/L
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit message:
SUMMARY
These fixes address issues with dependent filters using the "Select first filter value by default" option:
FilterValue.tsx: Prevents child filters from requesting data before their parent values are set. The request is now delayed until all parent filter data is available, ensuring correct first value selection.
SelectFilterPlugin: Ensures the first value is correctly updated when parent filter values change. A post-check hook verifies external data changes and selects the appropriate default.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
BEFORE
AFTER
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION