Skip to content

fix: Remove 'Stream' stacked style option for Bar charts #33841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

abhinav-1305
Copy link
Contributor

@abhinav-1305 abhinav-1305 commented Jun 20, 2025

SUMMARY

Ensures the 'Stream' option is not available for Bar charts in the Stacked Style control.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

Steps:

  1. Create or edit an ECharts Area chart.
  2. Set "Stacked Style" to "Stream".
  3. Change the chart type to ECharts Bar.
  4. Open the "Stacked Style" dropdown.

Expected: "Stream" is not present - only "None" and "Stack" are available.

ADDITIONAL INFORMATION

  • Has associated issue: resolves Remove the Stream Style Option for Bar Charts #33820
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dosubot dosubot bot added change:frontend Requires changing the frontend viz:charts:bar Related to the Bar chart labels Jun 20, 2025
Copy link

@korbit-ai korbit-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've completed my review and didn't find any issues.

Files scanned
File Path Reviewed
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/types.ts
superset-frontend/plugins/plugin-chart-echarts/src/constants.ts
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/Regular/Bar/controlPanel.tsx
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformProps.ts

Explore our documentation to understand the languages and file types we support and the files we ignore.

Check out our docs on how you can make Korbit work best for you and your team.

Loving Korbit!? Share us on LinkedIn Reddit and X

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

@sadpandajoe
Copy link
Member

@abhinav-1305 what happens to those who are using the stream option for bar charts? Won't this break for them or is this handled gracefully?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change:frontend Requires changing the frontend plugins size/M viz:charts:bar Related to the Bar chart
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the Stream Style Option for Bar Charts
2 participants