Skip to content

WIP: Templatizing SVG spinner #33782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 178 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
178 commits
Select commit Hold shift + click to select a range
336763f
feat: messing with the theme
mistercrunch Dec 20, 2024
352aa36
make Cancel secondary
mistercrunch Mar 2, 2025
8d36120
adjusting some buttons
mistercrunch Mar 2, 2025
ac81eef
fix types/tests
mistercrunch Mar 3, 2025
b2b7b89
fix unit test
mistercrunch Mar 4, 2025
22cbec1
ts-ignore
mistercrunch Mar 4, 2025
d131c29
fix a few buttons
mistercrunch Mar 4, 2025
b575aa6
make secondary filled/primary
mistercrunch Mar 4, 2025
6b5d53a
fix dashboard left panel background-color
mistercrunch Mar 4, 2025
d15c6d3
fixing storybook
mistercrunch Mar 4, 2025
4b55a92
set DARK ff to false
mistercrunch Mar 5, 2025
5faf018
switch primary color, keep old hex as comment in case we want to roll…
mistercrunch Mar 5, 2025
dbc7db9
rebased
mistercrunch Mar 17, 2025
2d461de
echarts
mistercrunch Mar 18, 2025
7dbe05f
fix treemap
mistercrunch Mar 19, 2025
f16600e
fix sankey theme
mistercrunch Mar 19, 2025
48df49d
fix BIG number
mistercrunch Mar 19, 2025
83f47d3
fixing vizes
mistercrunch Mar 19, 2025
2f80ebb
minor progress
mistercrunch Mar 19, 2025
e0d86df
merging
mistercrunch Mar 19, 2025
b9be692
fix MoreOutlined button background
mistercrunch Mar 19, 2025
9cb6c3b
color
mistercrunch Mar 19, 2025
1ca0f34
more button background
mistercrunch Mar 20, 2025
11bc496
echarts theming
mistercrunch Mar 20, 2025
b7bc111
Merge branch 'master' into template_less
mistercrunch Mar 20, 2025
358633e
some theming fixes
mistercrunch Mar 20, 2025
31eb105
touchups
mistercrunch Mar 24, 2025
4afbfd1
Merge branch 'master' into template_less
mistercrunch Mar 24, 2025
8ce1449
fix CopyOutlined icon in dataset view to align with sizing
mistercrunch Mar 24, 2025
56e3d16
theme toast icons and various cosmetic updates
mistercrunch Mar 24, 2025
5042248
Fix table row separator in TableCollection
mistercrunch Mar 24, 2025
59e402a
fix icon on Explore's cached label
mistercrunch Mar 24, 2025
cf68160
going vanila on tooltips
mistercrunch Mar 24, 2025
64c480a
aligning some colors tokens
mistercrunch Mar 25, 2025
54d67b6
fix table viz colors
mistercrunch Mar 25, 2025
11a29b1
fix Collapse color content
mistercrunch Mar 25, 2025
d3f450f
fix theme for ag-grid in SQL LAB
mistercrunch Mar 25, 2025
344c8f5
theming react-code-highlighter or whatev it's called
mistercrunch Mar 25, 2025
bcb6da1
Merge branch 'master' into template_less
mistercrunch Mar 25, 2025
cebff5e
improve styles in HighlightedSql
mistercrunch Mar 25, 2025
f949412
fix some tests
mistercrunch Mar 26, 2025
58724b1
fix test
mistercrunch Mar 26, 2025
7af32d4
fix theme test
mistercrunch Mar 26, 2025
023c7da
fix another test
mistercrunch Mar 26, 2025
aabeefb
fix types in Gauge/transformProps.test.ts
mistercrunch Mar 26, 2025
5418f09
fix test for BasicErrorAlert.tsx
mistercrunch Mar 26, 2025
1afa497
fix SavedQueries test
mistercrunch Mar 26, 2025
68ea9ac
fix ErrorMessageWithStackTrace
mistercrunch Mar 26, 2025
0472979
fix test in dashboard/actions.test.js
mistercrunch Mar 26, 2025
06d737e
add theming support to Storybook
mistercrunch Mar 27, 2025
d752b0f
fixing themes in Storybook
mistercrunch Mar 27, 2025
4f0a445
styling the AsyncAceEditor
mistercrunch Mar 27, 2025
5805f24
minor color tweak
mistercrunch Mar 27, 2025
3c289a9
a theme editor
mistercrunch Mar 27, 2025
f5b6806
ThemeEditor
mistercrunch Mar 27, 2025
6a15aaf
ThemeEditor
mistercrunch Mar 27, 2025
e7b2b58
Merge branch 'master' into template_less
mistercrunch Mar 27, 2025
5018749
fix cypress test
mistercrunch Mar 27, 2025
f217865
oopsy daisy
mistercrunch Mar 27, 2025
c31d70d
one minor edit to fix a cypress test
mistercrunch Mar 27, 2025
3665ebc
refactor(table): Upgrade table component from antd4 to antd5 (#32378)
EnxDev Mar 28, 2025
cde1da6
Merge branch 'master' into template_less
mistercrunch Mar 29, 2025
1dd8a76
set Global body bg color to colorBgBase
mistercrunch Mar 29, 2025
8b69958
centralize theming stuff in AsyncAceEditor
mistercrunch Mar 29, 2025
9dedb58
altering comment for THEME_OVERRIDES in superset/config.py
mistercrunch Mar 29, 2025
506c838
lint
mistercrunch Mar 29, 2025
e3342bb
Merge branch 'master' into template_less
mistercrunch Apr 1, 2025
9717159
refactor(form): Migrate Form component to Ant Design 5 (#32729)
msyavuz Apr 1, 2025
27d723f
force colorLink in GlobalStyles
mistercrunch Apr 1, 2025
952658e
fix links and bring GlobalStyles to superset-ui/core
mistercrunch Apr 1, 2025
d266835
remove console.log
mistercrunch Apr 1, 2025
70a5925
theming the viz picker
mistercrunch Apr 2, 2025
bc85a11
fix some type issues
mistercrunch Apr 2, 2025
6f73e58
refactor(theming): Fixes to previously migrated components (#32845)
msyavuz Apr 3, 2025
6b58ef1
feat: Theme to include brand logo configuration
mistercrunch Apr 2, 2025
2580a8b
Merge branch 'master' into template_less
mistercrunch Apr 3, 2025
e6df194
fix merge-related issues
mistercrunch Apr 3, 2025
6254db3
refactor(Components): Create wrappers for Ant Design 5 direct exports…
EnxDev Apr 7, 2025
33febb6
refactor(Tabs): Upgrade Tabs to Antd5 (#32810)
alexandrusoare Apr 7, 2025
c7d2881
Merge branch 'master' into template_less
mistercrunch Apr 7, 2025
3950cf0
refactor(Collapse): Upgrade Collapse to Antd5 (#32959)
DamianPendrak Apr 7, 2025
b835478
refactor(Select): Migrate Select component to Ant Design 5 (#32514)
msyavuz Apr 8, 2025
a9bc465
use colorBorder in AddSliceCard
mistercrunch Apr 7, 2025
c993abe
Merge branch 'master' into template_less
mistercrunch Apr 8, 2025
3b198ab
refactor(Table): Use our custom Table component in CRUD views (#32964)
msyavuz Apr 8, 2025
6c8e72b
Fix theming in Explore west panel - Search Input
mistercrunch Apr 8, 2025
7c2fd55
restyling page header and buttons
mistercrunch Apr 8, 2025
8bb02e2
fix: use Input & TextArea instead of native <input> and <textarea> (#…
mistercrunch Apr 8, 2025
739caa1
refactor(Checkbox): Upgrade component to Ant Design v5 (#32980)
payose Apr 9, 2025
6a4730b
Merge branch 'master' into template_less
mistercrunch Apr 9, 2025
c14dcec
refactor(breadcrumb): Upgrade Breadcrumb component from AntD v4 to An…
EnxDev Apr 11, 2025
662f33b
refactor(Components): Use named imports - P.1 (#33081)
geido Apr 11, 2025
4123d25
Merge branch 'master' into template_less
mistercrunch Apr 12, 2025
f18455c
fix a python build issue
mistercrunch Apr 12, 2025
29ba5ad
fix scripts/change_detector.py
mistercrunch Apr 12, 2025
2667a14
Merge branch 'master' into template_less
EnxDev Apr 14, 2025
334aa1a
fix a unit test
mistercrunch Apr 12, 2025
4f93c2d
Merge branch 'master' into template_less
mistercrunch Apr 15, 2025
dff7c1b
post merge conflicts
mistercrunch Apr 15, 2025
dcea6c0
fix imports
mistercrunch Apr 15, 2025
5e8cd7a
fix: provide id's
msyavuz Apr 15, 2025
18c3f0a
fix(theming): Fix various ci issues (#33147)
msyavuz Apr 16, 2025
86d5537
Merge branch 'master' into template_less
msyavuz Apr 16, 2025
08c9d28
Fix changes in DatasourcePanelItem after merge
kgabryje Apr 16, 2025
3fe5db1
refactor(Tabs): Tabs to use items instead of TabPanel (#33057)
alexandrusoare Apr 16, 2025
50535a9
fix: upgrade tabs in database modal (#33038)
DamianPendrak Apr 16, 2025
51f719f
set colorLink == colorPrimary
mistercrunch Apr 16, 2025
4709eb0
fix(Select): Merge conflicts and Select bug (#33165)
msyavuz Apr 24, 2025
6c01173
Merge branch 'master' into template_less
msyavuz Apr 24, 2025
d43657e
fix: post merge
msyavuz Apr 24, 2025
c217f56
refactor(components): Replace native HTML elements with Ant Design v5…
EnxDev Apr 25, 2025
a7b7e63
refactor(Table): Use Table instead of html <table> in CollectionTable…
msyavuz Apr 25, 2025
b040d52
refactor(Components): Use named imports - P.2 (#33249)
EnxDev Apr 25, 2025
f580da8
fix(Theming): DatabaseModal visual fixes (#33286)
msyavuz Apr 30, 2025
e529d84
fix: button colors and icons (#33287)
mistercrunch May 2, 2025
49bcf79
Merge branch 'master' into template_less
EnxDev May 5, 2025
9da62ed
refactor(InfoTooltipWithTrigger): Replace support for fa icons with a…
EnxDev May 5, 2025
8942489
Merge branch 'master' into template_less
mistercrunch May 5, 2025
fc031ca
fix: various theme-related tweaks and touches (#33372)
mistercrunch May 6, 2025
2c038f5
Merge branch 'master' into template_less
EnxDev May 7, 2025
d635c2a
fix: replace invalid theme tokens
EnxDev May 7, 2025
863a0be
Merge branch 'master' into template_less
mistercrunch May 7, 2025
3983ee0
fix category icon in VizPicker
mistercrunch May 9, 2025
5267ec2
fix DnD options caret and separator
mistercrunch May 9, 2025
67aa991
refactor(ui): replace native HTML elements with Ant Design 5 componen…
EnxDev May 12, 2025
7472714
Merge branch 'master' into template_less
msyavuz May 12, 2025
5b99180
fix: minor import issues
msyavuz May 12, 2025
cf68c87
fix: post merge fix imports
msyavuz May 12, 2025
1c28138
bigger icon in sql lab tab headers
mistercrunch May 9, 2025
f00adac
apply default theme boxShadow to cards
mistercrunch May 9, 2025
5a67713
Merge branch 'master' into template_less
mistercrunch May 13, 2025
e862b5c
more generic error catching
mistercrunch May 13, 2025
b03c425
fix(theming): Fix various visual regressions from theming (#33302)
msyavuz May 13, 2025
3997884
dummy commit to trigger CI
mistercrunch May 14, 2025
b9710f9
set the test for docker-compose-image-tag to only happen on merge to …
mistercrunch May 14, 2025
6fe8a54
fix the e2e GHA
mistercrunch May 14, 2025
14645a2
another try at fixing the GHA
mistercrunch May 14, 2025
7258dc9
fix(theming): Merge ci issues and new antd4 component to antd5 (#33429)
msyavuz May 14, 2025
fcea7e4
feat(theming): Support theming on embedding-sdk (#33360)
msyavuz May 14, 2025
33f2ffd
chore: rip antd-v4 from the app! (#33411)
mistercrunch May 15, 2025
0af5770
Merge branch 'master' into template_less
mistercrunch May 20, 2025
4070dba
fixing package-lock
mistercrunch May 20, 2025
20a17be
Merge branch 'master' into template_less
mistercrunch May 21, 2025
2979c30
fix(theming): Duplicate select values bug (#33558)
msyavuz May 22, 2025
c279d08
fix: remove all `less` styling! (#33445)
mistercrunch May 23, 2025
17ef5b6
fix native filters styling
mistercrunch May 23, 2025
8e48fdb
fix(theming): Fix visual regressions from theming P2/3 (#33587)
EnxDev May 27, 2025
58435e3
feat(Login): Migrate login page to frontend (#33255)
msyavuz May 29, 2025
28db9ad
chore: moving reusable components from `src/components` to `packages/…
mistercrunch May 31, 2025
9c7b676
fix Tooltip-related imports/exports
mistercrunch May 31, 2025
bd77f82
Merge branch 'master' into template_less
mistercrunch Jun 1, 2025
926d2bf
fix type errors
mistercrunch Jun 1, 2025
ef8ba1c
fix unit test live
mistercrunch Jun 1, 2025
90967c6
chore(CronPicker): Bump to v5.2.0 for full theming support (#33690)
EnxDev Jun 4, 2025
3eb04b0
Merge branch 'master' into template_less
EnxDev Jun 4, 2025
fd7b8f6
refactor(collapse): fix custom Collapse and align related imports pos…
EnxDev Jun 4, 2025
54e2c96
fix(RoleList): remove duplicate column
EnxDev Jun 4, 2025
3e34efe
Merge branch 'master' into template_less
EnxDev Jun 5, 2025
20a33b0
refactor(components): align related imports post-merge
EnxDev Jun 5, 2025
0315a37
Merge branch 'master' into template_less
mistercrunch Jun 6, 2025
4676f5c
fix(RTL test): update tab selector to avoid CSS pseudo-class parsing …
EnxDev Jun 8, 2025
84287be
fix(webpack): add stream-browserify fallback for Node.js 'stream' mod…
EnxDev Jun 8, 2025
04d0053
fix(deps): align geostyler versions to resolve dependency conflicts
EnxDev Jun 8, 2025
b41961a
fix(RTL test): adjust ResultsPaneOnDashboard.test.tsx to avoid invali…
EnxDev Jun 8, 2025
a9f744f
fix(tests): fix missing imports in DatasourceEditorCurrency.test and …
EnxDev Jun 8, 2025
0cacaba
refactor(Input Story): enhance type integration
EnxDev Jun 8, 2025
1eb65ec
refactor(UserInfo test): wrap render in await act to ensure state upd…
EnxDev Jun 8, 2025
33b069a
fix(RTL test): await asyncRender in DataSourceEditor.test to prevent …
EnxDev Jun 8, 2025
56089aa
Merge branch 'master' into template_less
msyavuz Jun 11, 2025
72fc7ac
fix(DatasourceEditor): clear mocks
msyavuz Jun 11, 2025
fa88197
fix(e2e): increase timeout
msyavuz Jun 12, 2025
96d7209
Merge branch master into template_less
EnxDev Jun 12, 2025
ae98d5f
refactor(DataSourceEditor tests): remove unused await and increase ti…
EnxDev Jun 12, 2025
253a72f
fix(theming): Fix visual regressions from theming P4 (#33703)
EnxDev Jun 12, 2025
1be1ca1
refactor(theming): Remove direct imports of supersetTheme (#33770)
msyavuz Jun 16, 2025
0a07520
feat(theming): implement a ThemeController (#33420)
msyavuz Jun 16, 2025
45a032a
fix(BaseIcon): Ensure iconSize is parsed correctly when passed as str…
EnxDev Jun 16, 2025
bbd19f9
templatizing spinner
rusackas Jun 16, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
echarts
  • Loading branch information
mistercrunch committed Mar 19, 2025
commit 2d461deb6885a1824bec71abeb846623c65e2759
Original file line number Diff line number Diff line change
@@ -26,8 +26,11 @@ import {
useCallback,
Ref,
} from 'react';
import merge from 'lodash/merge';

import { styled } from '@superset-ui/core';
import * as echarts from 'echarts';

import { styled, themeObject } from '@superset-ui/core';
import { use, init, EChartsType } from 'echarts/core';
import {
SankeyChart,
@@ -95,6 +98,57 @@ use([
LabelLayout,
]);

const getTheme = options => {
const token = themeObject.theme;
const theme = {
textStyle: {
color: token.colorText,
fontFamily: token.fontFamily,
},
title: {
textStyle: { color: token.colorText },
},
legend: {
textStyle: { color: token.colorTextSecondary },
},
tooltip: {
backgroundColor: token.colorBgContainer,
borderColor: token.colorSplit,
textStyle: { color: token.colorText },
},
axisPointer: {
lineStyle: { color: token.colorPrimary },
label: { color: token.colorText },
},
xAxis: {
axisLine: { lineStyle: { color: token.colorSplit } },
axisLabel: { color: token.colorTextSecondary },
splitLine: { lineStyle: { color: token.colorSplit } },
},
yAxis: {
axisLine: { lineStyle: { color: token.colorSplit } },
axisLabel: { color: token.colorTextSecondary },
splitLine: { lineStyle: { color: token.colorSplit } },
},
};
/*
if (options?.xAxis) {
theme.xAxis = {
axisLine: { lineStyle: { color: token.colorSplit } },
axisLabel: { color: token.colorTextSecondary },
splitLine: { lineStyle: { color: token.colorSplit } },
};
}
if (options?.yAxis) {
theme.yAxis = {
axisLine: { lineStyle: { color: token.colorSplit } },
axisLabel: { color: token.colorTextSecondary },
splitLine: { lineStyle: { color: token.colorSplit } },
};
} */
return theme;
};

function Echart(
{
width,
@@ -138,8 +192,12 @@ function Echart(
chartRef.current?.getZr().off(name);
chartRef.current?.getZr().on(name, handler);
});

/*
const themedEchartOptions = merge({}, getTheme(echartOptions), echartOptions);
*/
chartRef.current.setTheme(getTheme(echartOptions));
chartRef.current.setOption(echartOptions, true);
chartRef.current.setTheme(getTheme(echartOptions));
}, [echartOptions, eventHandlers, zrEventHandlers]);

// highlighting