Skip to content

fix: use risingwave as the sqlalchemy_uri_placeholder prefix for RisingWave engine #33764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

hzxa21
Copy link

@hzxa21 hzxa21 commented Jun 13, 2025

SUMMARY

Prior to this PR, when user choose RisingWave as the db engine, it will display postgresql://... as the sqlalchemy uri placeholder. However, this may cause issues when browsing the dataset because there are unsupported functionalities. Based on the official doc, risingwave:://... should be used so that sqlalchemy-risingwave will be chosen to be the driver.

This PR modifies the sqlalchemy_uri_placeholder for RisingWave engine and adds optional dependency for risingwave in pyproject.toml

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dosubot dosubot bot added the data:connect Namespace | Anything related to db connections / integrations label Jun 13, 2025
Copy link

@korbit-ai korbit-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've completed my review and didn't find any issues.

Files scanned
File Path Reviewed
superset/db_engine_specs/risingwave.py

Explore our documentation to understand the languages and file types we support and the files we ignore.

Check out our docs on how you can make Korbit work best for you and your team.

Loving Korbit!? Share us on LinkedIn Reddit and X

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but cc @betodealmeida to make sure I'm not missing some detail(s). Looks like the docs are up to date, which is nice :D

Copy link

codecov bot commented Jun 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.96%. Comparing base (76d897e) to head (95af377).
Report is 1964 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #33764       +/-   ##
===========================================
+ Coverage   60.48%   72.96%   +12.47%     
===========================================
  Files        1931      558     -1373     
  Lines       76236    40293    -35943     
  Branches     8568     4223     -4345     
===========================================
- Hits        46114    29399    -16715     
+ Misses      28017     9803    -18214     
+ Partials     2105     1091     -1014     
Flag Coverage Δ
hive 47.22% <100.00%> (-1.94%) ⬇️
javascript ?
mysql 71.95% <100.00%> (?)
postgres 72.01% <100.00%> (?)
presto 50.97% <100.00%> (-2.83%) ⬇️
python 72.92% <100.00%> (+9.42%) ⬆️
sqlite 71.52% <100.00%> (?)
unit 100.00% <ø> (+42.36%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:connect Namespace | Anything related to db connections / integrations size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants