Skip to content

chore: move backend under superset-backend #33722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

villebro
Copy link
Member

@villebro villebro commented Jun 8, 2025

SUMMARY

WIP

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@villebro villebro marked this pull request as draft June 8, 2025 23:24
@github-actions github-actions bot added the github_actions Pull requests that update GitHub Actions code label Jun 8, 2025
@dosubot dosubot bot added change:backend Requires changing the backend risk:refactor High risk as it involves large refactoring work labels Jun 8, 2025
Copy link

@korbit-ai korbit-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review by Korbit AI

Korbit automatically attempts to detect when you fix issues in new commits.
Category Issue Status
Functionality Missing directory existence check ▹ view 🧠 Not in standard
Files scanned

Due to the exceptionally large size of this PR, I've limited my review to the following files:

File Path Reviewed
superset-backend/setup.py
.github/workflows/bashlib.sh

Explore our documentation to understand the languages and file types we support and the files we ignore.

Check out our docs on how you can make Korbit work best for you and your team.

Loving Korbit!? Share us on LinkedIn Reddit and X

@@ -109,7 +109,7 @@ testdata() {
say "::group::Load test data"
# must specify PYTHONPATH to make `tests.superset_test_config` importable
export PYTHONPATH="$GITHUB_WORKSPACE"
pip install -e .
pip install -e superset-backend/.

This comment was marked as resolved.

@mistercrunch
Copy link
Member

mistercrunch commented Jun 9, 2025

Nice to see this! Wondering if you should take one step further and move to superset-backend/app/, assuming will be a need for things like superset-backend/extension-sdk/, superset-backend/data-access-layer/, all depending on something like superset-backend/core/ (?)

Oh also... now that there will be no pyproject.toml in the root (currently that makes it clear that it's a python project primarily and that you can pip install apache-superset), I'm wondering if we should have a Code Orientation section at the bottom of the readme giving pointers to important places across the monorepo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change:backend Requires changing the backend github_actions Pull requests that update GitHub Actions code review:draft risk:refactor High risk as it involves large refactoring work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants