feat(pivot-table-chart) -> download as pivoted excel #33569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review by Korbit AI
Korbit automatically attempts to detect when you fix issues in new commits.
| Category | Issue | Status |
|---|---|---|
 |
Unused XLSX Import ▹ view | 🧠 Not in scope |
Files scanned
| File Path | Reviewed |
|---|---|
| superset-frontend/src/utils/downloadAsPivotExcel.ts | ✅ |
| superset-frontend/src/dashboard/types.ts | ✅ |
| superset-frontend/src/dashboard/components/SliceHeader/index.tsx | ✅ |
| superset-frontend/src/explore/components/useExploreAdditionalActionsMenu/index.jsx | ✅ |
| superset-frontend/src/dashboard/components/gridComponents/Chart.jsx | ✅ |
| superset-frontend/src/dashboard/components/SliceHeaderControls/index.tsx | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Check out our docs on how you can make Korbit work best for you and your team.
| @@ -58,6 +58,8 @@ import { | |||
| } from '../../util/activeDashboardFilters'; | |||
| import getFormDataWithExtraFilters from '../../util/charts/getFormDataWithExtraFilters'; | |||
| import { PLACEHOLDER_DATASOURCE } from '../../constants'; | |||
| import * as XLSX from 'xlsx'; | |||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
There are a handful of issues related to pivot table downloads: https://github.com/search?q=repo%3Aapache%2Fsuperset+pivot+download&type=issues FYI in case you want to see if this PR addresses any of them, or could. |
msyavuz
added
the
preset:committed
|
Hey, @mdusmanalvi do you intend to continue the work on this? The feature works great, I can help push this through the finish line as it just needs the cleanup and tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Added the functionality of downloading charts as pivoted xlsx that is the the same structure will be seen in the downloaded file. This is implemented in two sections: while directly downloading charts and downloading charts from dashboards.
Library: https://www.npmjs.com/package/xlsx
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION