Skip to content

feat: Add Dashboard Filter Support for Alert Reports #32196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 91 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
91 commits
Select commit Hold shift + click to select a range
38bb661
placeholder dropdowns
hughhhh Jan 15, 2025
61d7c4f
Merge branch 'master' of https://github.com/apache/superset into hm/a…
hughhhh Jan 23, 2025
86ae7cc
filter dropdown working
hughhhh Jan 24, 2025
ecee690
saving ui work for now
hughhhh Jan 29, 2025
25d2850
Merge branch 'master' of https://github.com/apache/superset into hm/a…
hughhhh Jan 29, 2025
ef0a7ee
Merge branch 'master' of https://github.com/apache/superset into hm/a…
hughhhh Feb 3, 2025
16751c0
save
hughhhh Feb 7, 2025
47fc7de
remove print
hughhhh Feb 9, 2025
daf48cc
fixed params
hughhhh Feb 9, 2025
9b59d3a
allow for multiselect
hughhhh Feb 9, 2025
5fd0517
set edit
hughhhh Feb 10, 2025
689605d
update
hughhhh Feb 10, 2025
bf31b9d
ok add label
hughhhh Feb 10, 2025
2c06217
add filter additions
hughhhh Feb 13, 2025
c5c6d53
working multiple
hughhhh Feb 15, 2025
5202544
proper handle edit
hughhhh Feb 16, 2025
70ac1e7
ok
hughhhh Feb 16, 2025
24db175
save
hughhhh Feb 17, 2025
3da7656
fix colors
hughhhh Feb 22, 2025
81ace0f
update test
hughhhh Feb 22, 2025
1a41780
fix alignment
hughhhh Mar 1, 2025
45e1407
add tooltip
hughhhh Mar 1, 2025
10f2e0e
update filters
hughhhh Mar 3, 2025
082461b
ok
hughhhh Mar 3, 2025
6ab40e3
moved to emotion
hughhhh Mar 9, 2025
276d0f6
working
hughhhh Mar 9, 2025
a115b17
fix merge
hughhhh Mar 9, 2025
dae9428
fix linting
hughhhh Mar 9, 2025
263b290
lint
hughhhh Mar 9, 2025
def42d0
fix linting
hughhhh Mar 9, 2025
d20b764
linting
hughhhh Mar 10, 2025
f29c7e1
ignores on mypy
hughhhh Mar 11, 2025
a09b2a5
ok
hughhhh Mar 16, 2025
5d228f0
fix ci
hughhhh Mar 17, 2025
64bc357
ok
hughhhh Mar 18, 2025
3d40ece
Merge branch 'master' of https://github.com/apache/superset into hm/a…
hughhhh Mar 18, 2025
3efac9e
fix index
hughhhh Mar 18, 2025
945c467
fix duplicates on edit
hughhhh Mar 18, 2025
ebbe945
fix test
hughhhh Mar 18, 2025
f03cf9f
bad import
hughhhh Mar 18, 2025
b61e361
Merge branch 'master' into hm/ar-filters
eschutho Mar 18, 2025
e07fdb3
fix test
hughhhh Mar 19, 2025
951205f
fix ci fe build
hughhhh Mar 19, 2025
ee8862f
guard statement
hughhhh Mar 20, 2025
ae03821
fix Icons update
hughhhh Mar 25, 2025
4ce0b97
fix disables states
hughhhh Mar 27, 2025
243ce8d
allow filter selection without tabs
hughhhh Mar 27, 2025
32afe30
allowing for all filters to be query for better state
hughhhh Apr 2, 2025
8afdf82
ok
hughhhh Apr 3, 2025
b645634
Merge branch 'master' of https://github.com/apache/superset into hm/a…
hughhhh Apr 3, 2025
fde45f0
ok
hughhhh Apr 4, 2025
bd25d3c
update state management for adding new filters
hughhhh Apr 7, 2025
424d59f
add feature flag
hughhhh Apr 8, 2025
0d1422b
fix state with edit
hughhhh Apr 8, 2025
f2af658
add guard for .all
hughhhh Apr 8, 2025
cfce539
saving here for time_grain + time_column options
hughhhh Apr 15, 2025
3947ed3
remove console.logs
hughhhh Apr 17, 2025
bfd8694
fix encoding problem
hughhhh Apr 18, 2025
14d341a
fix unit test
hughhhh Apr 18, 2025
62b6b88
fix test
hughhhh Apr 19, 2025
0118aa2
fix test
hughhhh Apr 19, 2025
727d361
fix linting
hughhhh Apr 20, 2025
82c4d3e
restrict number of filters based on options
hughhhh Apr 20, 2025
3ce834e
fix length check
hughhhh Apr 21, 2025
7a043a8
fix ts-ignore
hughhhh Apr 28, 2025
83a1b99
fix more linting
hughhhh Apr 29, 2025
1b4e734
ok
hughhhh Apr 29, 2025
b0bd21d
transfer
hughhhh Apr 29, 2025
4763cd6
add small render test for dropdown
hughhhh May 1, 2025
029b682
change value
hughhhh May 7, 2025
2e6b69a
Merge branch 'master' of https://github.com/apache/superset into hm/a…
hughhhh May 7, 2025
519185c
do not allow filter_range type
hughhhh May 9, 2025
0b644bd
trash size
hughhhh May 9, 2025
3b14e11
Merge branch 'master' of https://github.com/apache/superset into hm/a…
hughhhh May 9, 2025
be87858
fix select
hughhhh May 9, 2025
667be47
fix linting
hughhhh May 9, 2025
d1e0e04
fix edit
hughhhh May 20, 2025
e5c463a
Merge branch 'master' of https://github.com/apache/superset into hm/a…
hughhhh May 22, 2025
b47fac6
Merge branch 'master' of https://github.com/apache/superset into hm/a…
hughhhh Jun 2, 2025
f1280c2
add filter for timecolumn
hughhhh Jun 2, 2025
e6caa17
fix hardcoded
hughhhh Jun 24, 2025
178b08c
Merge remote-tracking branch 'origin/master' into hm/ar-filters
hughhhh Jun 24, 2025
7dd4b5d
convert gridUnit to sizeUnit
hughhhh Jun 24, 2025
107e269
cleanup
hughhhh Jun 24, 2025
3c86c5f
Merge branch 'master' of https://github.com/apache/superset into hm/a…
Jul 11, 2025
22df03f
add adhoc filters to values query
Jul 11, 2025
90a29fe
add error states
Jul 11, 2025
4f5b21f
filter range v1
Jul 12, 2025
c1a215f
fix linting
Jul 12, 2025
3026fcc
fix test
Jul 12, 2025
7e0faad
o
Jul 12, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ export enum FeatureFlag {
AlertReports = 'ALERT_REPORTS',
AlertReportTabs = 'ALERT_REPORT_TABS',
AlertReportSlackV2 = 'ALERT_REPORT_SLACK_V2',
AlertReportsFilter = 'ALERT_REPORTS_FILTER',
AllowFullCsvExport = 'ALLOW_FULL_CSV_EXPORT',
AvoidColorsCollision = 'AVOID_COLORS_COLLISION',
ChartPluginsExperimental = 'CHART_PLUGINS_EXPERIMENTAL',
Expand Down
14 changes: 13 additions & 1 deletion superset-frontend/src/features/alerts/AlertReportModal.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -435,7 +435,7 @@ test('renders tab selection when Dashboard is selected', async () => {
expect(
screen.getByRole('combobox', { name: /dashboard/i }),
).toBeInTheDocument();
expect(screen.getByText(/select tab/i)).toBeInTheDocument();
expect(screen.getAllByText(/select tab/i)).toHaveLength(2);
});

test('changes to content options when chart is selected', async () => {
Expand Down Expand Up @@ -649,3 +649,15 @@ test('removes notification method on clicking trash can', async () => {
screen.getAllByRole('combobox', { name: /delivery method/i }).length,
).toBe(1);
});

test('renders dashboard filter dropdowns', async () => {
render(<AlertReportModal {...generateMockedProps(true, true)} />, {
useRedux: true,
});

userEvent.click(screen.getByTestId('contents-panel'));
const filterOptionDropdown = screen.getByRole('combobox', {
name: /select filter/i,
});
expect(filterOptionDropdown).toBeInTheDocument();
});
Loading
Loading